[FE-10707] Remove Node stuff from browser-connector #176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
israelvicars
approved these changes
Mar 10, 2020
jonvuri
deleted the
jrajav/FE-10707_remove-node-stuff-from-browser-connector
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Node requirements that are guarded with
isNodeRuntime()in mapd-con-es6 were being rolled up into the browser-connector bundle. This change declares them as externals in the browser webpack build, pointing to a shimmed no-op module, so that they don't get included in the browser-connector or anything that pulls it in as a UMD module.