Update connection parameters #239
Conversation
As per the new changes in core, update default user name and database name to admin and omnisci respectively Similar updates to documentation Update connection parameters unit tests
|
After discussion with @andrewseidl and looking at the changes, It seems like a good idea to make the remaining |
wamsiv
force-pushed
the
wam/update_unit_tests
branch
from
3394942
to
9e0d22f
Compare
| @@ -337,35 +337,53 @@ def test_dashboard_duplication_remap(self, con): | |||
| "title": new_dashboard_name | |||
| } | |||
| } | |||
| dashboard_id = "" | |||
| dashboards = [] | |||
There was a problem hiding this comment.
What is the purpose of this empty dashboards list? Does this get overwritten later if you fall into the exception?
There was a problem hiding this comment.
Yes, it just a function scope placeholder I initialized to be used in different places throughout.
| for dashboard in dashboards: | ||
| if dashboard.dashboard_name == old_dashboard_name: | ||
| dashboard_id = dashboard.dashboard_id | ||
| try: |
There was a problem hiding this comment.
I feel like the try/catch is overkill here. Ultimately this problem is one of cleaning up after the tests. Other tests just check for the presence of the thing being created and drop it (like a table existing already), then re-create it. Here, we're nesting the logic into try/catch and duplicating the code, when it would be much simpler to just make the test either clean up after itself or drop the dashboard before trying to create it again.
There was a problem hiding this comment.
This is more efficient in present circumstances than always looping over all dashboards each time. Here we only use getdasboards call when we have to for each case. Regarding duplication, I can move them to separate function.
|
@mattdh Please refer to here for latest changes. |
|
@wamsiv I just pushed a commit with a few final changes containing updated db name. Looks like the changes are working against the latest version. Tests being ran both pip and conda. |
|
Danke @mattdlh! The PR can be merged once Travis test passes. I have verified them locally. |
As per the new changes in core, update default user name and database name to
adminandomniscirespectivelySimilar updates to documentation
Update connection parameters unit tests
cc: @mattdlh
I have not changed the connection URL to start with
omnisci:It still starts with
mapdleft it to be in sync with repository namepymapd. Please let me know if that should be changed as well.