Skip to content

Commit

Permalink
Do not link bench and ctime_tests to COMMON_LIB
Browse files Browse the repository at this point in the history
The `bench` and `ctime_tests` are users of the library, they should only
be linked to the library, not the objects it was built from.
  • Loading branch information
hebasto committed Jan 30, 2023
1 parent e1817a6 commit ef39721
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions Makefile.am
Expand Up @@ -103,7 +103,7 @@ noinst_PROGRAMS =
if USE_BENCHMARK
noinst_PROGRAMS += bench bench_internal bench_ecmult
bench_SOURCES = src/bench.c
bench_LDADD = libsecp256k1.la $(COMMON_LIB)
bench_LDADD = libsecp256k1.la
bench_CPPFLAGS = $(SECP_CONFIG_DEFINES)
bench_internal_SOURCES = src/bench_internal.c
bench_internal_LDADD = $(COMMON_LIB) $(PRECOMPUTED_LIB)
Expand Down Expand Up @@ -134,7 +134,7 @@ endif
if USE_CTIME_TESTS
noinst_PROGRAMS += ctime_tests
ctime_tests_SOURCES = src/ctime_tests.c
ctime_tests_LDADD = libsecp256k1.la $(COMMON_LIB)
ctime_tests_LDADD = libsecp256k1.la
ctime_tests_CPPFLAGS = $(SECP_CONFIG_DEFINES)
endif

Expand Down

0 comments on commit ef39721

Please sign in to comment.