Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: 🚀 Remove Autotools-based build system #166

Draft
wants to merge 1 commit into
base: cmake-staging
Choose a base branch
from
Draft

build: 🚀 Remove Autotools-based build system #166

wants to merge 1 commit into from

Conversation

hebasto
Copy link
Owner

@hebasto hebasto commented Apr 23, 2024

The ultimate goal :)

@hebasto hebasto changed the title build: Remove Autotools-based build system build: 🚀 Remove Autotools-based build system Apr 24, 2024
vasild
vasild approved these changes Apr 24, 2024
View reviewed changes
Copy link

@vasild vasild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 51706e0

I guess if something is forgotten it can be removed later and it looks like nothing excessive is removed either (but doc/Doxygen file generation?)

.gitignore
.DS_Store
build
/build*
!/build-aux
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why unignore /build-aux?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To ensure that Autotools legacy won't sneak into CMake realm.

doc/.gitignore Show resolved Hide resolved
@hebasto hebasto mentioned this pull request Apr 27, 2024
Merged
@hebasto hebasto force-pushed the cmake-kill-autotools branch 2 times, most recently from 3a58eea to 9186936 Compare April 30, 2024 19:40
hebasto added a commit that referenced this pull request May 1, 2024
@hebasto
Merge #174: cmake, doc: Update depends/README.md
ce7e236 
fa4f450 cmake, doc: Update `depends/README.md` (Hennadii Stepanov)

Pull request description:

  Split from #166.

ACKs for top commit:
  m3dwards:
    ACK fa4f450

Tree-SHA512: fd1aff3ee2ac3bc9cf5ea9ceeb5cf4490325935e404e4f2b6cbf44ea9186f062bbc169f9772b812f2bb1a03728699c7f361a7a07d7c2d89f73246b54993a639c
@hebasto
Copy link
Owner Author

hebasto commented May 1, 2024

Unit tests create an artifact in the source tree:

share/rpcauth/__pycache__/rpcauth.cpython-312.pyc

@hebasto
Copy link
Owner Author

hebasto commented May 3, 2024

Unit tests create an artifact in the source tree:

share/rpcauth/__pycache__/rpcauth.cpython-312.pyc

Fixed.

vasild
vasild approved these changes May 14, 2024
View reviewed changes
Copy link

@vasild vasild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 7752690

@hebasto
Copy link
Owner Author

hebasto commented May 17, 2024

Rebased. More stuff have been removed from the src/univalue .

pablomartin4btc
pablomartin4btc reviewed May 23, 2024
View reviewed changes
Copy link

@pablomartin4btc pablomartin4btc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 44296a2

vasild
vasild approved these changes May 31, 2024
View reviewed changes
Copy link

@vasild vasild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 44296a2

@vasild
Copy link

vasild commented Jun 20, 2024

ACK 045f267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablomartin4btc pablomartin4btc pablomartin4btc left review comments

@vasild vasild vasild approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hebasto @vasild @pablomartin4btc