build: Add CMake-based build system (8 of N) #18

hebasto · 2023-07-12T13:24:34Z

The parent PR: bitcoin#25797.
The previous PRs in the staging branch: #5, #6, #7, #10, #13, #15, #17, #19.

What is NEW:

functions for checking compiler and linker flags
managing flags for different build types (configurations)

EXAMPLES of configuration output on Ubuntu 22.04:

for a single-config generator:

$ cmake .. -G "Unix Makefiles"
...
Cross compiling ....................... FALSE
Preprocessor defined macros ........... 
C compiler ............................ /usr/bin/cc
CFLAGS ................................ 
C++ compiler .......................... /usr/bin/c++
CXXFLAGS .............................. 
Common compile options ................ 
Common link options ................... 
Linker flags for executables .......... 
Linker flags for shared libraries ..... 
Build type (configuration):
 - CMAKE_BUILD_TYPE ................... RelWithDebInfo
 - Preprocessor defined macros ........ 
 - CFLAGS ............................. -O2 -g
 - CXXFLAGS ........................... -O2 -g
 - LDFLAGS for executables ............ 
 - LDFLAGS for shared libraries ....... 
Use assembly routines ................. ON
Use ccache for compiling .............. ON
...

for a multi-config generator:

$ cmake .. -G "Ninja Multi-Config"
...
Cross compiling ....................... FALSE
Preprocessor defined macros ........... 
C compiler ............................ /usr/bin/cc
CFLAGS ................................ 
C++ compiler .......................... /usr/bin/c++
CXXFLAGS .............................. 
Common compile options ................ 
Common link options ................... 
Linker flags for executables .......... 
Linker flags for shared libraries ..... 
Available build types (configurations)  RelWithDebInfo Debug Release
'RelWithDebInfo' build type (configuration):
 - Preprocessor defined macros ........ 
 - CFLAGS ............................. -O2 -g
 - CXXFLAGS ........................... -O2 -g
 - LDFLAGS for executables ............ 
 - LDFLAGS for shared libraries ....... 
'Debug' build type (configuration):
 - Preprocessor defined macros ........ DEBUG DEBUG_LOCKORDER DEBUG_LOCKCONTENTION RPC_DOC_CHECK ABORT_ON_FAILED_ASSUME
 - CFLAGS ............................. -O0 -g3
 - CXXFLAGS ........................... -O0 -g3 -ftrapv
 - LDFLAGS for executables ............ 
 - LDFLAGS for shared libraries ....... 
'Release' build type (configuration):
 - Preprocessor defined macros ........ 
 - CFLAGS ............................. -O2
 - CXXFLAGS ........................... -O2
 - LDFLAGS for executables ............ 
 - LDFLAGS for shared libraries ....... 
Use assembly routines ................. ON
Use ccache for compiling .............. ON
...

cross-compiling for Windows:

$ make -C depends HOST=x86_64-w64-mingw32 DEBUG=1 NO_QT=1
$ cmake -B build --toolchain depends/x86_64-w64-mingw32/share/toolchain.cmake -DCMAKE_BUILD_TYPE=Debug
...
Cross compiling ....................... TRUE, for Windows, x86_64
Preprocessor defined macros ........... _WIN32_WINNT=0x0601 _WIN32_IE=0x0501 WIN32_LEAN_AND_MEAN NOMINMAX WIN32 _WINDOWS _MT _GLIBCXX_DEBUG _GLIBCXX_DEBUG_PEDANTIC     
C compiler ............................ /usr/bin/x86_64-w64-mingw32-gcc
CFLAGS ................................ -pipe -std=c11 -O1
C++ compiler .......................... /usr/bin/x86_64-w64-mingw32-g++-posix
CXXFLAGS .............................. -pipe -std=c++17 -O1
Common compile options ................  
Common link options ................... -Wl,--major-subsystem-version,6 -Wl,--minor-subsystem-version,1
Linker flags for executables .......... -static
Linker flags for shared libraries ..... 
Build type (configuration):
 - CMAKE_BUILD_TYPE ................... Debug
 - Preprocessor defined macros ........ DEBUG DEBUG_LOCKORDER DEBUG_LOCKCONTENTION RPC_DOC_CHECK ABORT_ON_FAILED_ASSUME
 - CFLAGS ............................. -O0 -g3
 - CXXFLAGS ........................... -O0 -g3 -ftrapv
 - LDFLAGS for executables ............ 
 - LDFLAGS for shared libraries ....... 
Use assembly routines ................. ON
Use ccache for compiling .............. ON
...

A cross-project note. The ProcessConfigurations.cmake is based on the same module that was suggested in bitcoin-core/secp256k1#1291. So, cross-reviewing is welcome :)

hebasto · 2023-07-12T13:25:31Z

Friendly ping @TheCharlatan @theuni :)

hebasto · 2023-07-15T09:09:35Z

Does it make sense to encapsulate platform-specific preprocessor definitions, compiler and linker flags into an interface library, such as platform-specific? If so, it has to be linked to all targets.

hebasto · 2023-07-16T09:00:27Z

Prefixes of the parsed function arguments have been made abbreviated to improve code readability.

hebasto · 2023-07-16T14:05:29Z

Dropped unneeded locale normalization in the try_append_cxx_flags function as we use -Werror and do not rely on parsing warning messages at all.

hebasto · 2023-07-16T17:47:34Z

The try_append_linker_flag function has been reworked to force a linker to treat warnings as errors.

theuni

Quick review of the first 3 commits.

The 4th one is going to take more time and energy :)

cmake/module/TryAppendCXXFlags.cmake

theuni · 2023-07-18T15:09:04Z

cmake/module/TryAppendCXXFlags.cmake

+  if(MSVC)
+    set(CMAKE_REQUIRED_FLAGS "${flags} /WX")
+  else()
+    set(CMAKE_REQUIRED_FLAGS "${flags} -Werror")


I think this needs to remain an option to be passed in, similar to our autotools usage. 2 reasons:

The user might have passed in something stupid: cmake .. -DCMAKE_CXX_FLAGS="-Wbadflag"

A warning might not be an error

In the first case, every check will fail. This is not true in autotools because "-Werror" is only set after it has been tested itself. Here, it's hard-coded as working.

The second case is much more common. Imagine a compiler option that spews a deprecation message, but still works just fine. In that case, we'd want the ability to not pass in "Werror".

Edit: corrected "warning might not be an error".

theuni · 2023-07-18T15:12:56Z

cmake/module/TryAppendLinkerFlag.cmake

+
+  if(MSVC)
+    set(${linker_flags_var} ${flag} /WX)
+  elseif(CMAKE_SYSTEM_NAME STREQUAL "Darwin")


These are specific to the linker, not the platform.

The Darwin platform is in flux (moving to lld)

ld64 may be used on other platforms (BSDs)

So... I'm requesting as usual: please don't hard-code platforms like these. Test the flags and apply them if they work.

Also see "Werror" comment about making this an option. We don't always want fatal warnings.

Looking at our current impl, I see now you've mostly just ported over the old behavior.

Much of this seems quite janky to me, but I'll stop complaining about current behaviors. I might upstream a few changes though, and let you pick them up in a rebase.

Looking at our current impl, I see now you've mostly just ported over the old behavior.

Right. As we all were agree about that for the staging branch, IIRC.

Much of this seems quite janky to me, but I'll stop complaining about current behaviors. I might upstream a few changes though, and let you pick them up in a rebase.

Great!

ld64 may be used on other platforms (BSDs)

FWIW, I've successfully tested this PR on FreeBSD 13.2 and OpenBSD 7.1 using the default toolchains.

cmake/module/TryAppendLinkerFlag.cmake

theuni · 2023-07-18T15:57:08Z

CMakeLists.txt

+add_compile_definitions($<$<CONFIG:Debug>:ABORT_ON_FAILED_ASSUME>)
+# We leave assertions on.
+if(MSVC)
+  remove_c_flag_from_all_configs(/DNDEBUG)


This is a CPPFLAG (preprocessor) flag, not a cflag/cxxflag and not c/cxx specific. Surely it's possible to remove it from the list of definitions instead?

This is a CPPFLAG (preprocessor) flag, not a cflag/cxxflag and not c/cxx specific.

Agree :)

Surely it's possible to remove it from the list of definitions instead?

This is all about CMake's default platform-specific CMAKE_<LANG>_FLAGS_<CONFIG>_INIT variables. There are no preprocessor variable among them. And CMake indeed sets initial preprocessor definitions in the mentioned above language-specific variables.

Also: https://gitlab.kitware.com/cmake/cmake/-/issues/12928

CMakeLists.txt

theuni · 2023-07-18T16:12:10Z

CMakeLists.txt

+
+  # Prefer -O2 optimization level. (-O3 is CMake's default for Release for many compilers.)
+  replace_c_flag_in_config(Release -O3 -O2)
+  replace_cxx_flag_in_config(Release -O3 -O2)


I believe this means the user has no way to override and is stuck with "-O2" builds ?

FWIW, an issue with the user's opportunities to override build system options described in details in bitcoin-core/secp256k1#1249.

theuni · 2023-07-18T16:14:20Z

CMakeLists.txt

+  if(compiler_supports_O0)
+    string(STRIP "${debug_c_flags} -O0" debug_c_flags)
+  endif()
+  try_append_cxx_flags(debug_cxx_flags "-g3" RESULT_VAR compiler_supports_g3)


The "-g" flags should be on for Debug + RelWithDebInfo, off for MinSizeRel/Release. But it appears they're applied here unconditionally?

Hmm, though your multi-config output looks as I'd expect. I must be misunderstanding something. Ignore the above comment for now.

hebasto · 2023-07-19T16:16:12Z

The following @theuni's comments have been addressed:

hebasto · 2023-07-19T21:04:57Z

The PR description has been updated with an cross-compiling example.

ac7bc5b [FIXUP] Rename CCACHE_EXECUTABLE --> CCACHE_COMMAND for consistency (Hennadii Stepanov) 0476509 [FIXUP] Learn to work with recent ccache in MSVC builds (Hennadii Stepanov) 2fd67c7 [FIXUP] Do not disable `TrackFileAccess` in MSVC builds (Hennadii Stepanov) a53ae12 [FIXUP] Use Multi-ToolTask in MSVC builds by default (Hennadii Stepanov) Pull request description: The parent PR: bitcoin#25797. The previous PRs in the staging branch: #5, #6, #7, #10, #13, #15, #17, #18. This PR consists of fixups related to using [Ccache](https://ccache.dev/) in MSVC builds. Top commit has no ACKs. Tree-SHA512: dc01202b054aaeb5b46607bc93126bee0df523df3b4f2df54b566b2e2d6306d784a723fd4a999d0d84fdf31e926a72304790f94b9d57034db0c112ee9f52070e

maflcko

left two style-only nits

cmake/module/TryAppendCXXFlags.cmake

TheCharlatan · 2023-08-29T20:41:51Z

cmake/module/TryAppendCXXFlags.cmake

+
+  if(TACXXF_SOURCE)
+    set(source "${TACXXF_SOURCE}")
+    unset(${result} CACHE)


Is this removed from the cache in case the function was previously run with a RESULT_VAR argument and is now run with a SOURCE argument instead?

https://cmake.org/cmake/help/latest/module/CheckCXXSourceCompiles.html:

The check is only performed once, with the result cached in the variable named by <resultVar>. Every subsequent CMake run will re-use this cached value rather than performing the check again, even if the <code> changes. In order to force the check to be re-evaluated, the variable named by <resultVar> must be manually removed from the cache.

We are interested in performing checks whenever the tested source code is changed. This occurs when the SOURCE argument is added, omitted after being used before, or modified.

And it has nothing about the RESULT_VAR argument.

Reworked, because the previous branch version had a bug: skipping a check when the SOURCE argument is omitted after being used before.

cmake/module/ProcessConfigurations.cmake

theuni · 2023-08-31T19:17:16Z

cmake/module/ProcessConfigurations.cmake

@@ -0,0 +1,126 @@
+# Copyright (c) 2023 The Bitcoin Core developers


Is this entire file (excluding the printing) all just coping with -DNDEBUG? If so I'm wondering if there isn't an easier way...

Is this entire file (excluding the printing) all just coping with -DNDEBUG?

This file's goal (excluding the printing) is to adjust CMake's default platform-specific flags to our needs, particularly, to drop the NDEBUG preprocessor macro, lower optimization level from -O3 to -O2, and so on.

If so I'm wondering if there isn't an easier way...

I'll be happy with any suggestion to implement :)

Alternatively, we can define our custom default flags, which would override CMake's internal logic. However, I'd prefer to avoid this approach.

theuni · 2023-08-31T19:27:08Z

CMakeLists.txt

+    try_append_linker_flag(mingw_linker_flags "-Wl,--major-subsystem-version,6")
+    try_append_linker_flag(mingw_linker_flags "-Wl,--minor-subsystem-version,1")
+    separate_arguments(mingw_linker_flags)
+    add_link_options(${mingw_linker_flags})


It seems like a regression to set global flags here. In master we set these to CORE_LDFLAGS, which we pretty much use everywhere, but we can still opt-out.

I suspect we'll want to avoid setting any globals like this, in favor of manually applying flags where necessary.

How about making try_append_linker_flag take an output variable, to which it appends the flag if it succeeds? Pretty much how we do it in autoconf.

That is what I was asking in #18 (comment) :)

Reworked in 622171f.

Also see ae0c40e.

hebasto · 2023-09-02T10:57:36Z

Addressed @MarcoFalke's and @TheCharlatan's comments.

~~Still working on the recent @theuni's ones.~~ Done.

hebasto · 2023-09-02T17:52:03Z

@TheCharlatan @theuni @MarcoFalke

All your comments have been addressed.

Also I had to rebase due to the conflict with #19.

Hoping on your final (?) review :)

hebasto · 2023-09-02T19:34:12Z

Updated 04de82d -> a65da0d (cmake18.09 -> cmake18.10, diff):

fixed MSVC build, which was accidentality broken on the recent push.

theuni

ACK a65da0d to keep this moving. This has been sitting for too long :(

Thanks @hebasto for making the high-level review requests. I like the sanity checks too :)

I find myself getting bogged down by the details and corner-cases, which is probably not useful for this round of review. For example, I think it's safe to just assume TryAppendCXXFlags and friends work as expected for now.

theuni · 2023-09-13T15:44:02Z

depends/toolchain.cmake.in

@@ -73,6 +73,10 @@ if(NOT CMAKE_OBJCXX_COMPILER)
 endif()
 set(CMAKE_OBJCXX_FLAGS_INIT "${DEPENDS_OBJCXX_COMPILER_FLAGS} @CPPFLAGS@ @CXXFLAGS@")

+if(CMAKE_SYSTEM_NAME STREQUAL "Windows")
+  set(CMAKE_EXE_LINKER_FLAGS_INIT "-static")


Why is this moved to depends?

Using depends for Windows means the user cross-build on Linux. To be able to test binaries with Wine, they must be linked statically, no?

On the other hand, building on Windows natively does not require static linking.

Using depends for Windows means the user cross-build on Linux.

Yikes, please drop that assumption. I've maintained throughout review here that it makes more sense to me for MSVC to be using depends than a relying on external packagers. It's fine if that's not the default way, but please don't rule it out either.

Why is this moved to depends?

Reworked in #31.

theuni · 2023-09-13T15:44:42Z

CMakeLists.txt

@@ -280,3 +280,17 @@ if(configure_warnings)
    endforeach()
    message("  ******\n")
 endif()
+
+# We want all build properties to be encapsulated properly.
+get_directory_property(global_compile_definitions COMPILE_DEFINITIONS)


Sanity checking -- Love it!

…tifications fuzz target fab164f fuzz: Avoid signed-integer-overflow in wallet_notifications fuzz target (MarcoFalke) Pull request description: Should avoid ``` policy/feerate.cpp:29:63: runtime error: signed integer overflow: 77600710321911316 * 149 cannot be represented in type 'int64_t' (aka 'long') #0 0x563a1775ed66 in CFeeRate::GetFee(unsigned int) const src/policy/feerate.cpp:29:63 #1 0x563a15913a69 in wallet::COutput::COutput(COutPoint const&, CTxOut const&, int, int, bool, bool, bool, long, bool, std::optional<CFeeRate>) src/./wallet/coinselection.h:91:57 #2 0x563a16fa6a6d in wallet::FetchSelectedInputs(wallet::CWallet const&, wallet::CCoinControl const&, wallet::CoinSelectionParams const&) src/wallet/spend.cpp:297:17 #3 0x563a16fc4512 in wallet::CreateTransactionInternal(wallet::CWallet&, std::vector<wallet::CRecipient, std::allocator<wallet::CRecipient>> const&, int, wallet::CCoinControl const&, bool) src/wallet/spend.cpp:1105:33 #4 0x563a16fbec74 in wallet::CreateTransaction(wallet::CWallet&, std::vector<wallet::CRecipient, std::allocator<wallet::CRecipient>> const&, int, wallet::CCoinControl const&, bool) src/wallet/spend.cpp:1291:16 #5 0x563a16fcf6df in wallet::FundTransaction(wallet::CWallet&, CMutableTransaction&, long&, int&, bilingual_str&, bool, std::set<int, std::less<int>, std::allocator<int>> const&, wallet::CCoinControl) src/wallet/spend.cpp:1361:16 #6 0x563a1597b7b9 in wallet::(anonymous namespace)::FuzzedWallet::FundTx(FuzzedDataProvider&, CMutableTransaction) src/wallet/test/fuzz/notifications.cpp:162:15 #7 0x563a15958240 in wallet::(anonymous namespace)::wallet_notifications_fuzz_target(Span<unsigned char const>)::$_0::operator()() const src/wallet/test/fuzz/notifications.cpp:228:23 #8 0x563a15958240 in unsigned long CallOneOf<wallet::(anonymous namespace)::wallet_notifications_fuzz_target(Span<unsigned char const>)::$_0, wallet::(anonymous namespace)::wallet_notifications_fuzz_target(Span<unsigned char const>)::$_1>(FuzzedDataProvider&, wallet::(anonymous namespace)::wallet_notifications_fuzz_target(Span<unsigned char const>)::$_0, wallet::(anonymous namespace)::wallet_notifications_fuzz_target(Span<unsigned char const>)::$_1) src/./test/fuzz/util.h:43:27 #9 0x563a15958240 in wallet::(anonymous namespace)::wallet_notifications_fuzz_target(Span<unsigned char const>) src/wallet/test/fuzz/notifications.cpp:196:9 #10 0x563a15fdef0c in std::function<void (Span<unsigned char const>)>::operator()(Span<unsigned char const>) const /usr/bin/../lib/gcc/x86_64-linux-gnu/13/../../../../include/c++/13/bits/std_function.h:591:9 #11 0x563a15fdef0c in LLVMFuzzerTestOneInput src/test/fuzz/fuzz.cpp:178:5 #12 0x563a158032a4 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x19822a4) (BuildId: 8acb42ad599d7f6d25b6f93e18fd564d80df7c06) #13 0x563a15802999 in fuzzer::Fuzzer::RunOne(unsigned char const*, unsigned long, bool, fuzzer::InputInfo*, bool, bool*) (/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x1981999) (BuildId: 8acb42ad599d7f6d25b6f93e18fd564d80df7c06) #14 0x563a15804586 in fuzzer::Fuzzer::ReadAndExecuteSeedCorpora(std::vector<fuzzer::SizedFile, std::allocator<fuzzer::SizedFile>>&) (/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x1983586) (BuildId: 8acb42ad599d7f6d25b6f93e18fd564d80df7c06) #15 0x563a15804aa7 in fuzzer::Fuzzer::Loop(std::vector<fuzzer::SizedFile, std::allocator<fuzzer::SizedFile>>&) (/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x1983aa7) (BuildId: 8acb42ad599d7f6d25b6f93e18fd564d80df7c06) #16 0x563a157f21fb in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x19711fb) (BuildId: 8acb42ad599d7f6d25b6f93e18fd564d80df7c06) #17 0x563a1581c766 in main (/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x199b766) (BuildId: 8acb42ad599d7f6d25b6f93e18fd564d80df7c06) #18 0x7f499e17b0cf (/lib/x86_64-linux-gnu/libc.so.6+0x280cf) (BuildId: 96ab1a8f3b2c9a2ed37c7388615e6a726d037e89) #19 0x7f499e17b188 in __libc_start_main (/lib/x86_64-linux-gnu/libc.so.6+0x28188) (BuildId: 96ab1a8f3b2c9a2ed37c7388615e6a726d037e89) #20 0x563a157e70c4 in _start (/ci_container_base/ci/scratch/build/bitcoin-x86_64-pc-linux-gnu/src/test/fuzz/fuzz+0x19660c4) (BuildId: 8acb42ad599d7f6d25b6f93e18fd564d80df7c06) SUMMARY: UndefinedBehaviorSanitizer: signed-integer-overflow policy/feerate.cpp:29:63 in MS: 0 ; base unit: 0000000000000000000000000000000000000000 0x3f,0x0,0x2f,0x5f,0x5f,0x5f,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0x7d,0xff,0xff,0xff,0xff,0xff,0x53,0xff,0xff,0xff,0xff,0xff,0x0,0x0,0x0,0x0,0x0,0x0,0x13,0x5e,0x5f,0x5f,0x8,0x25,0x0,0x5f,0x5f,0x5f,0x5f,0x5f,0x5f,0x8,0x25,0xca,0x7f,0x5f,0x5f,0x5f,0x13,0x13,0x5f,0x5f,0x5f,0x2,0xdb,0xca,0x0,0x0,0xe7,0xe6,0x66,0x65,0x0,0x0,0x0,0x0,0x44,0x3f,0xa,0xa,0xff,0xff,0xff,0xff,0xff,0x61,0x76,0x6f,0x69,0x0,0xb5,0x15, ?\000/___}}}}}}}}}}}}}}}}}}}}\377\377\377\377\377S\377\377\377\377\377\000\000\000\000\000\000\023^__\010%\000______\010%\312\177___\023\023___\002\333\312\000\000\347\346fe\000\000\000\000D?\012\012\377\377\377\377\377avoi\000\265\025 artifact_prefix='./'; Test unit written to ./crash-4d3bac8a64d4e58b2f0943e6d28e6e1f16328d7d Base64: PwAvX19ffX19fX19fX19fX19fX19fX19fX3//////1P//////wAAAAAAABNeX18IJQBfX19fX18IJcp/X19fExNfX18C28oAAOfmZmUAAAAARD8KCv//////YXZvaQC1FQ== ACKs for top commit: dergoegge: ACK fab164f brunoerg: ACK fab164f Tree-SHA512: f416828f4394aa7303ee437f141e9bbd23c0e0f1b830e4ef3932338858249ba68a811b9837c5b7ad8c6ab871b6354996434183597c1a910a8d8e8d829693e4b2

hebasto mentioned this pull request Jul 13, 2023

build: Add CMake-based build system (9 of N) #19

Merged

hebasto force-pushed the 230712-cmake-H branch from a2740c4 to 514a1a0 Compare July 16, 2023 08:58

hebasto force-pushed the 230712-cmake-H branch 2 times, most recently from add16ca to e947768 Compare July 16, 2023 14:05

hebasto force-pushed the 230712-cmake-H branch from e947768 to dba171f Compare July 16, 2023 17:46

theuni reviewed Jul 18, 2023

View reviewed changes

hebasto force-pushed the 230712-cmake-H branch from dba171f to f365f4b Compare July 19, 2023 16:12

hebasto mentioned this pull request Jul 20, 2023

build: Windows debug cross-build fails with -O0 bitcoin/bitcoin#28109

Open

1 task

maflcko reviewed Aug 28, 2023

View reviewed changes

cmake/module/TryAppendCXXFlags.cmake Outdated Show resolved Hide resolved

cmake/module/TryAppendCXXFlags.cmake Outdated Show resolved Hide resolved

TheCharlatan reviewed Aug 29, 2023

View reviewed changes

TheCharlatan reviewed Aug 30, 2023

View reviewed changes

cmake/module/ProcessConfigurations.cmake Outdated Show resolved Hide resolved

theuni reviewed Aug 31, 2023

View reviewed changes

hebasto force-pushed the 230712-cmake-H branch from f365f4b to c594ac3 Compare September 2, 2023 10:56

hebasto force-pushed the 230712-cmake-H branch 2 times, most recently from 30df9fa to 04de82d Compare September 2, 2023 17:48

hebasto added 4 commits September 2, 2023 20:29

[FIXUP] Encapsulate common build flags into core interface library

7903bd5

cmake: Add TryAppendCXXFlags module

ae430cf

cmake: Add TryAppendLinkerFlag module

e0621e9

cmake: Add platform-specific flags

3736470

hebasto added 3 commits September 2, 2023 20:29

cmake: Warn about not encapsulated build properties

482e844

[FIXUP] Evaluate flags set in depends _after_ config-specific flags

1a1dda5

cmake: Redefine configuration flags

a65da0d

hebasto force-pushed the 230712-cmake-H branch from 04de82d to a65da0d Compare September 2, 2023 19:30

theuni approved these changes Sep 13, 2023

View reviewed changes

hebasto merged commit 92e4391 into cmake-staging Sep 13, 2023

hebasto mentioned this pull request Sep 16, 2023

Rebased cmake-staging branch (post PRs 17, 18, 19) #31

Closed

hebasto mentioned this pull request Oct 6, 2023

CMake-based build system tracking issue bitcoin/bitcoin#28607

Open

16 tasks

hebasto mentioned this pull request Jan 24, 2024

cmake: Rework handling compiler flags #82

Merged

		@@ -0,0 +1,126 @@
		# Copyright (c) 2023 The Bitcoin Core developers

build: Add CMake-based build system (8 of N) #18

build: Add CMake-based build system (8 of N) #18

Conversation

hebasto commented Jul 12, 2023 • edited

hebasto commented Jul 12, 2023

hebasto commented Jul 15, 2023 • edited

hebasto commented Jul 16, 2023

hebasto commented Jul 16, 2023

hebasto commented Jul 16, 2023

theuni left a comment

Choose a reason for hiding this comment

theuni Jul 18, 2023 • edited

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hebasto commented Jul 19, 2023

hebasto commented Jul 19, 2023

maflcko left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hebasto commented Sep 2, 2023 • edited

hebasto commented Sep 2, 2023

hebasto commented Sep 2, 2023

theuni left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

hebasto commented Jul 12, 2023 •

edited

hebasto commented Jul 15, 2023 •

edited

theuni Jul 18, 2023 •

edited

hebasto commented Sep 2, 2023 •

edited