Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[config:export] simplify the creation of the target directory #3054

Merged
merged 1 commit into from Jan 1, 2017

Conversation

@ao2
Copy link
Contributor

ao2 commented Dec 29, 2016

Dear maintainer,

this is a cleanup change, so I did not open an issue for it, but I can do so if it is required.

Thanks,
Antonio

The $directory variable is a loop invariant, there is no need to try to
create the directory for each configuration entry, so move the creation
of the target directory out of the loop.

While at it move it also before the $tar conditional block, in this way
the same code will be used whether --tar has been used or not.
@jmolivas jmolivas merged commit 85cac52 into hechoendrupal:master Jan 1, 2017
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jmolivas

This comment has been minimized.

Copy link
Member

jmolivas commented Jan 1, 2017

@ao2 Thanks for your contribution, your PR was merged. This will be included on the next release.

@jmolivas jmolivas added this to the 1.0.0-rc13 milestone Jan 1, 2017
@ao2 ao2 deleted the ao2:config-export-simplify-creation-of-target-dir branch Jan 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.