Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scftemplatetest #519

Merged
merged 2 commits into from
Oct 18, 2012
Merged

Scftemplatetest #519

merged 2 commits into from
Oct 18, 2012

Conversation

edgurgel
Copy link
Contributor

@edgurgel edgurgel commented Sep 7, 2012

This commit adds the missing setFloat (SuperCfResult has the getFloat method) and include tests for these set/getTypes:

  • String
  • UUID
  • Long
  • Integer
  • Double
  • Float
  • Boolean
  • Byte array
  • Date

@zznate
Copy link
Collaborator

zznate commented Sep 7, 2012

Huh - may not be you, but do all your tests pass when you run a clean install from the root hector dir?

@edgurgel
Copy link
Contributor Author

edgurgel commented Sep 7, 2012

Nope, but since I started to build the master branch, no clean full test passed...
I'm trying to figure out which test is not working...
But you can checkout the master branch before my commits and test :P

@zznate
Copy link
Collaborator

zznate commented Sep 7, 2012

Ok - I can reproduce this here, looks like something is borking in object-mapper test execution. I'll pull this in after I fix that (so the CI system stops complaining :)

Thanks!

@edgurgel
Copy link
Contributor Author

edgurgel commented Sep 7, 2012

A good way to prevent this things is using http://travis-ci.org/ . Travis run tests against master branch and github pull requests. Free for open source projects. You just need to add a .travis.yml file in the master branch with:
language: java

@zznate
Copy link
Collaborator

zznate commented Sep 7, 2012

@edgurgel I only just figured this out because it appears to be running already :)

See the bottom of the text box for your original issue description above. Thanks though!

@patricioe
Copy link
Collaborator

I noticed our continues build in cloud bees is not working.

I will fix that next monday.
On Sep 7, 2012 8:29 AM, "Eduardo Gurgel" notifications@github.com wrote:

A good way to prevent this things is using http://travis-ci.org/ . Travis
run tests against master branch and github pull requests. Free for open
source projects. You just need to add a .travis.yml file in the master
branch with:
language: java


Reply to this email directly or view it on GitHubhttps://github.com//pull/519#issuecomment-8368735.

@edgurgel
Copy link
Contributor Author

edgurgel commented Sep 7, 2012

@zznate Oh cool. :D
I "installed" it on my fork. Forgot that :P

@edgurgel
Copy link
Contributor Author

Any news? :)

zznate added a commit that referenced this pull request Oct 18, 2012
@zznate zznate merged commit f764d6f into hector-client:master Oct 18, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants