Revert "config: Add a flag to control the /metrics and /status endpoints" #3251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sigh i hate the 1.x code so much... Please sign off the commit. |
freesteph
force-pushed
the
revert-3219-fix/custom-observability
branch
from
df78d8f
to
090bb8f
Compare
…nts" This reverts commit d10ead4. Signed-off-by: Stéphane Maniaci <stephane.maniaci@beta.gouv.fr>
freesteph
force-pushed
the
revert-3219-fix/custom-observability
branch
from
090bb8f
to
b79e09e
Compare
|
Done. Apologies for not noticing this beforehand, next time I'll make sure our changesets get tested in our own environments first. |
|
It's okay. There is a reason why we're rewriting this unpredictable mess 🙃 |
|
Tbh: I don't think that it's necessary to revert EVERYTHING. Just revert the code for deactivation of the status route and keep the code that deactivates the metrics route because the metrics route is the sensible one. |
mrdrogdrog
requested review from
DerMolly,
mrdrogdrog,
davidmehren,
ErikMichelson and
InnayTool
mrdrogdrog
approved these changes
Feb 5, 2023
DerMolly
approved these changes
Feb 5, 2023
ErikMichelson
approved these changes
Feb 5, 2023
|
I've merged this PR to repair the master branch. If you still want to deactivate the metric route then feel free to create a new PR. |
|
Sorry I was busy this weekend, I'll push a new PR soon. Thanks for taking care of this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #3219
Apologies there's a bug in the PR above. Hedgedoc uses the
/configendpoint to transmit some information client-side, via writing into thewindowobject.Though I don't think it's a great mechanism, I don't have a patch yet to work around it, so revert the previous PR in the meantime.