fix(webpack): give reveal.js's marked.js a 'exports' variable #4114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I really don't know why this breaks only in a production build, but this evil hack makes the script work again. Closes #3862 Signed-off-by: David Mehren <git@herrmehren.de>
davidmehren
force-pushed
the
3862-speaker-notes-are-not-rendered-on-speaker-mode
branch
from
c78776d
to
f9796fb
Compare
mrdrogdrog
deleted the
3862-speaker-notes-are-not-rendered-on-speaker-mode
branch
davidmehren
added a commit
that referenced
this pull request
Jun 4, 2023
#4114 did not properly fix the missing speaker notes. It turns out that by just excluding reveal.js/plugin/markdown/marked.js from esbuild processing, we can stop invalid JS from being generated. Signed-off-by: David Mehren <git@herrmehren.de>
2 tasks
davidmehren
added a commit
that referenced
this pull request
Jun 4, 2023
#4114 did not properly fix the missing speaker notes. It turns out that by just excluding reveal.js/plugin/markdown/marked.js from esbuild processing, we can stop invalid JS from being generated. Signed-off-by: David Mehren <git@herrmehren.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component/Part
Webpack config
Description
I really don't know why this breaks only in a production build, but this
evil hack makes the script work again.
Closes #3862
Steps
made sure that:
masterfor 1.x & docs,developfor 2.xRelated Issue(s)