fix(esbuild): exclude reveal.js marked plugin #4161
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component/Part
Webpack config
Description
#4114
did not properly fix the missing speaker notes.
It turns out that by just excluding
reveal.js/plugin/markdown/marked.js
from esbuild processing, we can stop invalid JS from being generated.
Steps
made sure that:
master
for 1.x & docs,develop
for 2.xRelated Issue(s)