Fix performance issues with color handling #345
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..by not autodetecting
UseColor
on everyupdateSummary
if it is not provided.detectColor
is expensive because it callshSupportsANSI
, which can result in lookup of 3 environment variables and a call toIODevice.isTerminal
.This commit replaces several cases of
Maybe UseColor
withUseColor
and detects/resolves color explicitly incheck
,recheck
andcheckGroup
.See my earlier comment for performance numbers I collected while testing.