Fix performance issues with color handling #345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
..by not autodetecting it on every `Hedgehog.Internal.Runner.updateSummary`. `Hedgehog.Internal.Config.detectColor` is expensive because it calls `hSupportsANSI`, which can result in lookup of 3 environment variables and a call to `IODevice.isTerminal`. This commit replaces several cases of `Maybe UseColor` with `UseColor` and detects/resolves color explicitly in `check`, `recheck` and `checkGroup`.
|
Related: #240 |
|
This looks very reasonable. |
moodmosaic
approved these changes
Dec 29, 2019
There was a problem hiding this comment.
Looks good 👍 The only concern here is that it'll require a major version bump due to the change in the type signatures /cc @jacobstanley
|
I think these are all internal modules so maybe not? |
|
Yeah, indeed 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
..by not autodetecting
UseColoron everyupdateSummaryif it is not provided.detectColoris expensive because it callshSupportsANSI, which can result in lookup of 3 environment variables and a call toIODevice.isTerminal.This commit replaces several cases of
Maybe UseColorwithUseColorand detects/resolves color explicitly incheck,recheckandcheckGroup.See my earlier comment for performance numbers I collected while testing.