-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add evalNF #384
Add evalNF #384
Conversation
I'm ok with modifying the existing |
I think we don't have any tests for the You could add a module to I'm cool with having no test though as it's so trivial. |
Or even make a new top-level one called |
Yep, basically we use haskell-hedgehog/hedgehog/src/Hedgehog/Internal/Property.hs Lines 726 to 732 in 4ec7254
Here's one of those examples: haskell-hedgehog/hedgehog-example/src/Test/Example/Basic.hs Lines 50 to 55 in 4ec7254
|
Thanks for the feedback! I've added |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Thank you, @dcastro! |
Added
evalNF
as discussed in #383.A couple of things:
failException'
, which behaves exactly likefailException
except it also prints━━━ Value could not be evaluated to normal form ━━━
. Alternatively, we could simply change the type offailException
to take an additional list of lines to be printed.failException
is internal this would not be a breaking change, but still inconvenient... Any thoughts on whether we should refactorfailException
or leave the local bind forfailException'
in?evalNF
. I tried searching for tests for the existingeval
, but couldn't find any. Should I add any tests and, if so, to which project/module?either
andeither_
fromHedgehog.Gen
in my previous PR, so I did that here, if that's OK. I can also submit this is a separate PR if you'd prefer.