Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter with multiple languages #106

Closed
Blurry1Wang opened this issue Nov 16, 2021 · 8 comments
Closed

Filter with multiple languages #106

Blurry1Wang opened this issue Nov 16, 2021 · 8 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers to try

Comments

@Blurry1Wang
Copy link

First, the project is very useful! Thanks for creating it! However, it's kinda embarrassing that we can only search on one language once a time.
Can we add multiple language support so that we can search based on various combination of languages? Like python and c++

@hedyhli hedyhli added enhancement New feature or request good first issue Good for newcomers to try labels Nov 16, 2021
@hedyhli hedyhli changed the title Feature: Language Filter with multiple language support Filter with multiple languages Nov 16, 2021
@hedyhli
Copy link
Owner

hedyhli commented Nov 16, 2021

Thanks for bringing this up, it would be a nice feature! It can be achieved by specifying multiple languages with +language:a+language:b when querying GitHub. We can possibly allow --lang to be specified multiple times or with commas: --lang=python --lang=cpp or --lang=python,cpp.

@fgsepter
Copy link

Hi! My friend and I think this is a very good start for our contribution to GitHub. Could we work on this? :)

  • I understand that I have asked to solve two issues, but we also have two people here. So it should be not that hard. Hope you can assign us the issues, thx!

@larissalages
Copy link

Hello @hedyhli ! Could I work in this issue?

@fgsepter
Copy link

fgsepter commented Dec 3, 2021

@hedyhli Hello, I've submitted a pull request to enable filtering with the combination of languages and spoken languages.
Currently, we are able to use -l Python+JavaScript and -S en+zh.

larissalages added a commit to larissalages/starcli that referenced this issue Dec 3, 2021
larissalages added a commit to larissalages/starcli that referenced this issue Dec 3, 2021
@larissalages larissalages mentioned this issue Dec 3, 2021
4 tasks
@hedyhli hedyhli linked a pull request Dec 4, 2021 that will close this issue
4 tasks
@hedyhli
Copy link
Owner

hedyhli commented Dec 4, 2021

Hello @hedyhli ! Could I work in this issue?

Hey @larissalages thanks for you interest but I'll let @fgsepter have a go at this first since they asked first 😄

larissalages added a commit to larissalages/starcli that referenced this issue Dec 7, 2021
@Ladeia
Copy link

Ladeia commented Sep 23, 2022

This work still open? Can I work on this?

@vaibhavb
Copy link

Do you still need help? I can pick it up

@hedyhli
Copy link
Owner

hedyhli commented Jan 11, 2023

Closing as implemented (#116).

@hedyhli hedyhli closed this as completed Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers to try
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants