Skip to content

Commit

Permalink
[FIX, CHORE] Updates @codemirror/view (#4803)
Browse files Browse the repository at this point in the history
**Description**

Updates the version of @codemirror/view, which is the component of CodeMirror that handles the UI of the library, to the last version. The issue we were experiencing with the gutter was actually caused by a bug in the library.

**Fixes #4776**

**How to test**

Go to level 12 and delete all of the code in the editor, then copy and paste this code:

```
define simple_function_1 with parameter
    print 'simple_function_1 - 1'
    m = 'simple_function_1 - 2'
    print m
define simple_function_2 with param
    print 'simple_function_2 - 1'
    print param
define simple_function_3 with param_a, param_b, param_c
    if param_a = 'A'
        print 'simple_function_3 - 1'
        print param_b
    else
        print 'simple_function_3 - 2'
        if param_a = 'B'
            print 'simple_function_3 - 2A'
            print param_b
        else
            print 'simple_function_3 - 2B'
            print param_c
a = 'test1'
print call simple_function_3 with 'A', a, 1.0
call simple_function_3 with 'B', a, 1.0
call simple_function_3 with 'C', a, 1.0
```

On this branch version the gutter should be shown correctly, as opposed to alpha.
  • Loading branch information
jpelay committed Dec 4, 2023
1 parent d94ef30 commit a815afc
Show file tree
Hide file tree
Showing 4 changed files with 46 additions and 46 deletions.
14 changes: 7 additions & 7 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
"@codemirror/commands": "^6.2.5",
"@codemirror/state": "^6.2.1",
"@codemirror/theme-one-dark": "^6.1.2",
"@codemirror/view": "^6.18.0",
"@codemirror/view": "^6.22.1",
"@istanbuljs/nyc-config-typescript": "^1.0.2",
"@lezer/generator": "^1.5.1",
"@lezer/highlight": "^1.1.6",
Expand Down
72 changes: 36 additions & 36 deletions static/js/appbundle.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions static/js/appbundle.js.map

Large diffs are not rendered by default.

0 comments on commit a815afc

Please sign in to comment.