Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX, CHORE] Updates @codemirror/view #4803

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Conversation

jpelay
Copy link
Member

@jpelay jpelay commented Nov 24, 2023

Description

Updates the version of @codemirror/view, which is the component of CodeMirror that handles the UI of the library, to the last version. The issue we were experiencing with the gutter was actually caused by a bug in the library.

Fixes #4776

How to test

Go to level 12 and delete all of the code in the editor, then copy and paste this code:

define simple_function_1 with parameter
    print 'simple_function_1 - 1'
    m = 'simple_function_1 - 2'
    print m
define simple_function_2 with param
    print 'simple_function_2 - 1'
    print param
define simple_function_3 with param_a, param_b, param_c
    if param_a = 'A'
        print 'simple_function_3 - 1'
        print param_b
    else
        print 'simple_function_3 - 2'
        if param_a = 'B'
            print 'simple_function_3 - 2A'
            print param_b
        else
            print 'simple_function_3 - 2B'
            print param_c
a = 'test1'
print call simple_function_3 with 'A', a, 1.0
call simple_function_3 with 'B', a, 1.0
call simple_function_3 with 'C', a, 1.0

On this branch version the gutter should be shown correctly, as opposed to alpha.

Copy link
Contributor

mergify bot commented Nov 28, 2023

⚠️ The sha of the head commit of this PR conflicts with #4801. Mergify cannot evaluate rules on this PR. ⚠️

@jpelay jpelay reopened this Nov 28, 2023
@jpelay jpelay requested a review from hasan-sh December 4, 2023 14:28
Copy link
Collaborator

@hasan-sh hasan-sh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fixes the issue.

Copy link
Contributor

mergify bot commented Dec 4, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

Copy link
Contributor

mergify bot commented Dec 4, 2023

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit a815afc into hedyorg:main Dec 4, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Gutter not being displayed correctly when copying and pasting code
2 participants