[FIX] Highlight unterminated quoted strings differently than correctly terminated quoted strings.

[antoineveldhoven]

Description

• Remove styling for unterminated quoted strings in Level 4;
  For educational purposes (the essence of Level 4) do not highlight incorrect termination of quotations.
• Mark unterminated quoted strings as invalid for Level 5 and above

Fixes #3768

How to test

Level 4 and above

• Go to http://localhost:8080/hedy/4#default
• Observe the 2nd example code
  

Checklist
Done? Check if you have it all in place using this list:*

• Contains one of the PR categories in the name
• Describes changes in the format above
• Links to an existing issue or discussion
• Has a "How to test" section

[Felienne]

Thanks @antoineveldhoven!! This highlighting for level 4 for sure is better than what we have now!

But I am not sure I like the "heavy" highlighting in the higher levels. It is not bad in itself, but it is a bit out of tone maybe with what we have for other errors.

Shall we do it in steps and first highlight unterminated strings in white in all levels? Then we can experiment with the pink later on separately (I would love to test drive it in class for a bit)

[Felienne]

Ow yes and the highlighting has tests that are now broken, do let us know if you need help to fix them!

[antoineveldhoven]

Ow yes and the highlighting has tests that are now broken, do let us know if you need help to fix them!

First time commiter here 🙋‍♂️ 🤦‍♂️
Will have a (better) look at the tests and resubmit my PR.

[Felienne]

Ow yes and the highlighting has tests that are now broken, do let us know if you need help to fix them!

First time commiter here 🙋‍♂️ 🤦‍♂️ Will have a (better) look at the tests and resubmit my PR.

No problemo! That was actually why the tests did not run (first timers have to be manually approved). Do reach out if we can help (here or in Discord)

[antoineveldhoven]

Ow yes and the highlighting has tests that are now broken, do let us know if you need help to fix them!

First time commiter here 🙋‍♂️ 🤦‍♂️ Will have a (better) look at the tests and resubmit my PR.

No problemo! That was actually why the tests did not run (first timers have to be manually approved). Do reach out if we can help (here or in Discord)

Thnx for the review; I've updated this PR, can you have another look, assuming the tests run fine this time 😜

[Felienne]

Ow yes and the highlighting has tests that are now broken, do let us know if you need help to fix them!

First time commiter here 🙋‍♂️ 🤦‍♂️ Will have a (better) look at the tests and resubmit my PR.

No problemo! That was actually why the tests did not run (first timers have to be manually approved). Do reach out if we can help (here or in Discord)

Thnx for the review; I've updated this PR, can you have another look, assuming the tests run fine this time 😜

Let's see ;) I will also send you an invite to the repo, that way your PRs will run the tests automatically!

[Felienne]

Thanks @antoineveldhoven, all good now!

And congrats on getting your first PR approved!!! 🥳

[mergify]

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork).

[antoineveldhoven]

Thanks @antoineveldhoven, all good now!

And congrats on getting your first PR approved!!! 🥳

thnx, also for the fix in the print test!

[Felienne]

I have also opened a Discussion for your other idea: #4169 Will ask a few teachers to chip in with their opinion!