🪲 Change TWElements select to our owns #5438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into fix-level-warnings
hasan-sh
reviewed
Apr 30, 2024
templates/customize-adventure.html
Outdated
Comment on lines
86
to
93
| <div class="flex-1"> | ||
| <select id="language" name="language" required class="toggle-button font-semibold rounded inline-flex justify-between appearance-none w-full border-2 bg-gray-100 text-gray-700 p-2 rounded"> | ||
| <option value="{{ adventure['language'] or current_language().lang }}" selected>{{ lang_to_sym(adventure['language'] or current_language().lang) }}</option> | ||
| {% for language in other_languages(adventure["language"]) %} | ||
| <option value="{{language.lang}}">{{language.sym}}</option> | ||
| {% endfor %} | ||
| </select> | ||
| </div> |
There was a problem hiding this comment.
Shall we convert this dropdown to our own as well?? It'd feel more consistent!
templates/customize-adventure.html
Outdated
Comment on lines
100
to
109
| <input type="text" name="tag" autocomplete="off" placeholder="{{_('tag_input_placeholder')}}" id="search_tags_input" | ||
| class="appearance-none w-full bg-gray-200 border border-gray-200 text-gray-700 py-3 px-4 ltr:pr-8 rtl:pl-8 rounded" | ||
| hx-trigger="enter" | ||
| hx-post="/tags/create/{{adventure.id}}" | ||
| hx-target="#tags-list" | ||
| hx-swap="outerHTML" | ||
| _="on click event.stopPropagation() | ||
| on keypress if event.keyCode == 13 event.stopPropagation() end | ||
| on htmx:afterRequest set my value to '' then focus()" | ||
| > |
There was a problem hiding this comment.
Suggested change
| <input type="text" name="tag" autocomplete="off" placeholder="{{_('tag_input_placeholder')}}" id="search_tags_input" | |
| class="appearance-none w-full bg-gray-200 border border-gray-200 text-gray-700 py-3 px-4 ltr:pr-8 rtl:pl-8 rounded" | |
| hx-trigger="enter" | |
| hx-post="/tags/create/{{adventure.id}}" | |
| hx-target="#tags-list" | |
| hx-swap="outerHTML" | |
| _="on click event.stopPropagation() | |
| on keypress if event.keyCode == 13 event.stopPropagation() end | |
| on htmx:afterRequest set my value to '' then focus()" | |
| > | |
| <input type="text" name="tag" autocomplete="off" placeholder="{{_('tag_input_placeholder')}}" id="search_tags_input" | |
| data-autosaved="true" | |
| class="appearance-none w-full bg-gray-200 border border-gray-200 text-gray-700 py-3 px-4 ltr:pr-8 rtl:pl-8 rounded" | |
| hx-trigger="keyup[keyCode == 13]" | |
| hx-post="/tags/create/{{adventure.id}}" hx-target="#tags-list" hx-swap="outerHTML" | |
| _="on click event.stopPropagation() | |
| on keypress if event.keyCode == 13 event.stopPropagation() end | |
| on htmx:beforeRequest event.preventDefault() then if my value == '' then detail.xhr.abort() end | |
| on htmx:afterRequest set my value to '' then focus()" | |
| > |
Comment on lines
+110
to
+111
| <button class="green-btn" id="add_adventure_tags" | ||
| hx-trigger="click" |
There was a problem hiding this comment.
@jpelay the type="button" property needs to be added to the preview button as well, because if we click enter now, it opens the preview!
Suggested change
| <button class="green-btn" id="add_adventure_tags" | |
| hx-trigger="click" | |
| <button class="green-btn" id="add_adventure_tags" | |
| type="button" | |
| hx-trigger="click" |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request is now going on the merge train (choo choo! Do not click update from main anymore, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current dropdowns are part of a paid library and therefore are very hard to target in JS. Replace them with Hasan's select to be able to have control over them.
Fixes #5290
How to test
Customizing an adventure should work normally