hdb: hdb_ldap_common NULL dereference

In hdb_ldap_common() the test if (search_base == NULL && search_base[0] == '\0') error handling ... must be if (search_base == NULL || search_base[0] == '\0') error handling ... Change-Id: I8d876a9c56833431b3c4b582fbb0a8cc7353893d
heimdal · Nov 14, 2016 · 19e8852 · 19e8852
1 parent 95c2940
commit 19e8852
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/lib/hdb/hdb-ldap.c b/lib/hdb/hdb-ldap.c
@@ -1905,7 +1905,7 @@ hdb_ldap_common(krb5_context context,
 	url = p;
     }
 
-    if (search_base == NULL && search_base[0] == '\0') {
+    if (search_base == NULL || search_base[0] == '\0') {
 	krb5_set_error_message(context, ENOMEM, "ldap search base not configured");
 	return ENOMEM; /* XXX */
     }