kdc s4u2proxy fixes for Windows (Samba AD) clients #1156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abartlet
approved these changes
Jun 10, 2023
|
This looks pretty good! I'll do a careful review later today or tomorrow. Thanks for the contribution! |
|
@nicowilliams could we get this looked at please, it would help us keep our tree closer to Heimdal master, which helps us all I hope. |
|
I've also confirmed this still builds clean on linux after rebasing. |
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13131 Signed-off-by: Stefan Metzmacher <metze@samba.org>
We need to do this after checking for constraint delegation (S4U2Proxy). BUG: https://bugzilla.samba.org/show_bug.cgi?id=13131 Signed-off-by: Stefan Metzmacher <metze@samba.org>
…o use the keys from evidence_tkt BUG: https://bugzilla.samba.org/show_bug.cgi?id=13131 Signed-off-by: Stefan Metzmacher <metze@samba.org>
…ickets BUG: https://bugzilla.samba.org/show_bug.cgi?id=13137 Signed-off-by: Stefan Metzmacher <metze@samba.org>
metze-samba
force-pushed
the
heimdal-s4u2proxy
branch
from
8bc5a4a
to
66a5c02
Compare
metze-samba
added a commit
to metze-samba/heimdal
that referenced
this pull request
Mar 1, 2024
BUG: https://bugzilla.samba.org/show_bug.cgi?id=13131 Signed-off-by: Stefan Metzmacher <metze@samba.org> MR: heimdal#1156
metze-samba
added a commit
to metze-samba/heimdal
that referenced
this pull request
Mar 1, 2024
We need to do this after checking for constraint delegation (S4U2Proxy). BUG: https://bugzilla.samba.org/show_bug.cgi?id=13131 Signed-off-by: Stefan Metzmacher <metze@samba.org> MR: heimdal#1156
metze-samba
added a commit
to metze-samba/heimdal
that referenced
this pull request
Mar 1, 2024
…o use the keys from evidence_tkt BUG: https://bugzilla.samba.org/show_bug.cgi?id=13131 Signed-off-by: Stefan Metzmacher <metze@samba.org> MR: heimdal#1156
metze-samba
added a commit
to metze-samba/heimdal
that referenced
this pull request
Mar 1, 2024
…ickets BUG: https://bugzilla.samba.org/show_bug.cgi?id=13137 Signed-off-by: Stefan Metzmacher <metze@samba.org> MR: heimdal#1156
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further details can be found here:
https://bugzilla.samba.org/show_bug.cgi?id=13131
(S4U2Proxy requests with encrypted authorization-data are rejected by a Samba KDC)
https://bugzilla.samba.org/show_bug.cgi?id=13137
S4U2Proxy tickets from a Samba KDC don't pass PAC verification checks (authtime mismatch)
Here are the same changes including tests demonstrating
the problems and that they are fixed with the kdc changes:
https://gitlab.com/samba-team/samba/-/merge_requests/2458