Support later Visual Studio releases better #1190
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have these headers and types on later Visual Studio versions, so make sure these are defined in these cases.
Visual Studio 2010 and later ship with stdint.h, and 2013 and later ship with stdbool.h, so don't copy compatibility versions of these headers as Heimdal headers in these cases as they could break builds with other programs badly, such as items that include the inttypes.h that ship with later Visual Studio releases.
If we set in the MAKEINFO=... in the NMake commandline, such as callin makeinfo using PERL, ensure that we honor this when calling NTMakefile.w32.
|
It seems there are bigger issues with the windows build sadly. |
|
Hi. |
|
The logs are available to me when logged in, but likely not guests. So I attach the zip file. |
|
|
|
The problem may be this in which I think builds |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This attempts to make the Heimdal builds against later Visual Studio better, by:
include\config.w32to define thatstdint.handinttypes.h(and the related types) are available, when Visual Studio 2010 or later and Visual Studio 2013 or later are used, respectively, since these headers are shipped with these versions of Visual Studio.windows\NTMakefile.configandlib\roken\NTMakefileto reflect on the availability ofstdint.handstdbool.h, which are available since Visual Studio 2010 and Visual Studio 2013, repsectively. As a consequence, the compatibility headers for these headers that comes inlib\rokenis not copied in cases where Visual Studio ships with them). This will fix builds that use Heimdal that is horribly broken when when the systeminttypes.his included, as things in the compatibilitystdint.hwill clash with the system'sinttypes.hbadly.makeinfo.execall inwindows\NTMakefile.w32to instead use whatever that that is passed in throught envvars or the NMake command line.With blessings, thank you!