krb5: Correct inverted conditions #1230
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jo Sutton <josutton@catalyst.net.nz>
jsutton24
force-pushed
the
block-dns-inverted-condition
branch
from
b2ab34b
to
0a7e360
Compare
jsutton24
changed the title
|
LGTM, thanks for the extra eyeballs on this! I reviewed all the references to the block_dns option again in master as of 1b62220 and it looks like these are the only ones I got backwards. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix inverted logic introduced by #1155 that results in DNS not working if
block_dnsisfalse, rather thantrue.