Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redefinition errors on ppc64 linux #191

Closed
wants to merge 1 commit into from
Closed

Redefinition errors on ppc64 linux #191

wants to merge 1 commit into from

Conversation

dmulder
Copy link
Contributor

@dmulder dmulder commented Aug 2, 2016

These defines cause redefinition warnings on most platforms/compilers. On ppc64 linux with gcc 4.7 it caused an error.

@jaltman
Copy link
Member

jaltman commented Aug 2, 2016

The correct define for Windows is _WIN32 but the correct fix for this is to include the header file in roken.h.in that defines EAFNOSUPPORT and EWOULDBLOCK.

@dmulder
Copy link
Contributor Author

dmulder commented Aug 2, 2016

Those defines are in errno.h, which if you look in roken.h.in, it's already included.
Maybe the failure here is that HAVE_ERRNO_H isn't defined? That should be defined in config.h, but I don't see config.h included anywhere in roken.h.in.

@lhoward
Copy link
Member

lhoward commented Dec 27, 2018

@dmulder, where are the redefinition warnings coming from? Perhaps the problem is that they are not including config.h before roken.h?

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants