Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some little cleanups #391

Closed
wants to merge 4 commits into from
Closed

Some little cleanups #391

wants to merge 4 commits into from

Conversation

iboukris
Copy link
Contributor

No description provided.

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Signed-off-by: Isaac Boukris <iboukris@gmail.com>
Found by binary printouts in logs.

Signed-off-by: Isaac Boukris <iboukris@gmail.com>
@nicowilliams
Copy link
Contributor

Commit 0a67e64 should be removed. Just because the ccache isn't currently being used in those functions doesn't mean that it doesn't belong, and we might want to use it in the future for accessing things like ccconfig entries. Builds should not be failing, but we wouldn't object to adding a (void)id; to such functions.

@nicowilliams nicowilliams added this to the Heimdal 8 milestone Dec 14, 2018
Copy link
Member

@jaltman jaltman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resubmit the pull request without the

get_cred: avoid passing ccache id" change

@nicowilliams
Copy link
Contributor

Cherry-picked and pushed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants