This repository has been archived by the owner on Jul 6, 2023. It is now read-only.
tests: Make tests safe for personal machines #846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
thanks for your patch, @purpleidea ! |
obnoxxx
suggested changes
Sep 10, 2017
tests/functional/run.sh
Outdated
| @@ -7,7 +7,9 @@ TESTS="TestManyBricksVolume $TESTS" | |||
|
|
|||
| # install glide | |||
| if ! command -v glide ; then | |||
| curl https://glide.sh/get | sh | |||
| echo glide is not installed | |||
| echo 'run "curl https://glide.sh/get | sh" if you are crazy' | |||
There was a problem hiding this comment.
please use more appropriate language ;-)
In the main Makefile we already have:
Please install glide.
Install it using your package manager or
by running: curl https://glide.sh/get | sh.
this may be not perfect but I think it's better.
purpleidea
force-pushed
the
feat/safe-machine
branch
from
b55abce
to
6e5b989
Compare
|
patch updated. |
This is totally unsafe to run in an environment that I use. Okay, for travis, but not here. This should fix it, since this is already in travis.
purpleidea
force-pushed
the
feat/safe-machine
branch
from
6e5b989
to
3c2773e
Compare
|
(now rebased to master) |
obnoxxx
approved these changes
Sep 12, 2017
|
LGTM, thanks |
|
w00t! first patch |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is totally unsafe to run in an environment that I use. Okay, for
travis, but not here. This should fix it, since this is already in
travis.