New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated phpsass library to fix PHP 7 bug #21

Merged
merged 3 commits into from Mar 1, 2018

Conversation

Projects
None yet
2 participants
@KZeni
Copy link
Contributor

KZeni commented Oct 20, 2017

Fixed PHP 7 bug as mentioned by issue #19 by patching in the the latest master branch from https://github.com/richthegeek/phpsass as the version of the phpsass library that was previously being used had a PHP 7 bug.

KZeni added some commits Oct 20, 2017

@KZeni KZeni referenced this pull request Oct 20, 2017

Closed

PHP bug #19

@helen

This comment has been minimized.

Copy link
Owner

helen commented Mar 1, 2018

@KZeni Thanks for the PR! I'm finally getting around to reviewing this. I think I will try pushing some more changes to your branch so I can get this closed up - basically, I would rather not bundle in unnecessary things such as tests and extensions.

@KZeni

This comment has been minimized.

Copy link
Contributor

KZeni commented Mar 1, 2018

@helen Ah, good point. Thanks!

@helen

This comment has been minimized.

Copy link
Owner

helen commented Mar 1, 2018

@KZeni I really just wanted to try this ability to push to somebody else's branch, I'm sure you would have made the changes quickly :) Anyway, something isn't working on my end but I have a feeling it's not because of this PR but because of something else, so I'm just going to merge this for now and work on the other things I need to do to ship a new release (like #2).

@helen helen added this to the 2.0 milestone Mar 1, 2018

@helen helen merged commit 4538600 into helen:develop Mar 1, 2018

@KZeni

This comment has been minimized.

Copy link
Contributor

KZeni commented Mar 1, 2018

Gotcha. Thanks again! 🎉

@KZeni

This comment has been minimized.

Copy link
Contributor

KZeni commented Jun 15, 2018

It appears this update hasn't been pushed to the WP.org plugin repository yet. Any cause for delay I can assist with?

@KZeni KZeni referenced this pull request Nov 12, 2018

Open

Support PHP 7 #24

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment