Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modifiers + single-press fires unexpectedly #527

Closed
helgoboss opened this issue Feb 6, 2022 · 0 comments
Closed

Modifiers + single-press fires unexpectedly #527

helgoboss opened this issue Feb 6, 2022 · 0 comments
Labels
bug Something isn't working realearn Related to ReaLearn

Comments

@helgoboss
Copy link
Owner

  1. Press modifier
  2. Do single press and quickly release modifier => Single press NOT fired
  3. After a while press modifier again => Single press fired!

Probably needs to be fixed in helgoboss-learn
@helgoboss helgoboss added the bug Something isn't working label Feb 6, 2022
helgoboss added a commit that referenced this issue Feb 6, 2022
@helgoboss
#527 Quick fix for unexpected fire mode firing after mapping activation
d5f0fa0
helgoboss added a commit that referenced this issue Feb 6, 2022
@helgoboss
#527 Fix by polling even mappings for which control is disabled
8e56434 
This has a nice effect: It makes the time when the button is pressed
relevant and lets subsequent bank/modifier changes not have any influence
on the merits of "Fire after timeout", "Single press" etc. That's
actually what we want. A modifier doesn't need to be pressed the whole
time, just in the beginning. Nice!
@helgoboss helgoboss added the realearn Related to ReaLearn label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working realearn Related to ReaLearn
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@helgoboss