[BUGFIX] Add tests that cover latest regressions

Add tests for TYPO3-Console#868 and TYPO3-Console#869

.php_cs.dist

@@ -87,5 +87,6 @@ return PhpCsFixer\Config::create()
             ->exclude('Libraries')
             ->notName('ext_emconf.php')
             ->notName('ext_localconf.php')
+            ->notName('ext_tables.php')
             ->notName('ComposerPackagesCommands.php')
     );

.styleci.yml

@@ -70,4 +70,5 @@ finder:
   not-name:
     - "ext_emconf.php"
     - "ext_localconf.php"
+    - "ext_tables.php"
     - "ComposerPackagesCommands.php"

Tests/Console/Functional/Command/Install/InstallCommandControllerTest.php

@@ -116,6 +116,27 @@ public function setupEvaluatesStepFileIfGiven()
         $this->assertNotContains('Set up extensions', $output);
     }
 
+    /**
+     * @test
+     */
+    public function deprecatedSetupOptionNonInteractiveWorks()
+    {
+        $output = $this->executeConsoleCommand(
+            'install:setup',
+            [
+                '--non-interactive',
+                '--skip-integrity-check',
+            ],
+            [
+                'TYPO3_INSTALL_SETUP_STEPS' => __DIR__ . '/../../Fixtures/Install/custom-install.yaml',
+            ]
+        );
+        $this->assertContains('Successfully installed TYPO3 CMS!', $output);
+        $this->assertContains('Custom step', $output);
+        $this->assertContains('Option --non-interactive is deprecated. Please use --no-interaction instead.', $output);
+        $this->assertNotContains('Set up extensions', $output);
+    }
+
     /**
      * @test
      */

Tests/Console/Functional/Command/UpgradeCommandControllerTest.php

@@ -63,6 +63,36 @@ public function checkExtensionConstraintsReturnsErrorCodeOnFailure()
         $this->removeFixtureExtensionCode('ext_test');
     }
 
+    /**
+     * @test
+     */
+    public function checkExtensionCompatibilityReportsBrokenCodeInExtTables()
+    {
+        $this->installFixtureExtensionCode('ext_broken_ext_tables');
+        $this->executeConsoleCommand('install:generatepackagestates');
+
+        $output = $this->commandDispatcher->executeCommand('upgrade:checkextensioncompatibility', ['ext_broken_ext_tables']);
+        $this->assertSame('false', $output);
+
+        $this->removeFixtureExtensionCode('ext_broken_ext_tables');
+        $this->executeConsoleCommand('install:generatepackagestates');
+    }
+
+    /**
+     * @test
+     */
+    public function checkExtensionCompatibilityDoeNotReportBrokenCodeInExtTablesWithConfigOnlyCheck()
+    {
+        $this->installFixtureExtensionCode('ext_broken_ext_tables');
+        $this->executeConsoleCommand('install:generatepackagestates');
+
+        $output = $this->commandDispatcher->executeCommand('upgrade:checkextensioncompatibility', ['ext_broken_ext_tables', '--config-only']);
+        $this->assertSame('true', $output);
+
+        $this->removeFixtureExtensionCode('ext_broken_ext_tables');
+        $this->executeConsoleCommand('install:generatepackagestates');
+    }
+
     /**
      * @test
      */

Tests/Console/Functional/Fixtures/Extensions/ext_broken_ext_tables/ext_emconf.php

@@ -0,0 +1,24 @@
+<?php
+$EM_CONF[$_EXTKEY] = [
+  'title' => 'Test Extension',
+  'description' => 'Extension fixture to prove extension compat check is working correctly',
+  'category' => 'cli',
+  'state' => 'stable',
+  'uploadfolder' => 0,
+  'createDirs' => '',
+  'modify_tables' => '',
+  'clearCacheOnLoad' => 0,
+  'author' => 'Helmut Hummel',
+  'author_email' => 'info@helhum.io',
+  'author_company' => 'helhum.io',
+  'version' => '0.1.0',
+  'constraints' => [
+    'depends' => [
+      'typo3' => '9.5.0-',
+    ],
+    'conflicts' => [
+    ],
+    'suggests' => [
+    ],
+  ],
+];

Tests/Console/Functional/Fixtures/Extensions/ext_broken_ext_tables/ext_localconf.php

@@ -0,0 +1,2 @@
+<?php
+defined('TYPO3_MODE') or die();

Tests/Console/Functional/Fixtures/Extensions/ext_broken_ext_tables/ext_tables.php

@@ -0,0 +1,4 @@
+<?php
+defined('TYPO3_MODE') or die();
+
+throw new \Exception('broken', 1576697261);