Skip to content

Commit

Permalink
Fix SLF4J binding for annotation processors (#7706)
Browse files Browse the repository at this point in the history
Add slf4j-api as a dependency to inject/tools.
This ensures when the compiler plugin resolves the processor transitive dependencies the resolved version of slf4j-api is the managed version.
Otherwise we may end-up with different versions between slf4j-api and slf4j-jdk14 and a failed binding with the warning.

Fixes #7129
  • Loading branch information
romain-grecourt committed Oct 3, 2023
1 parent 53cc3c1 commit fd84ce5
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions inject/tools/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,10 @@
</dependency>
<dependency>
<!-- required as handlebars use slf4j -->
<groupId>org.slf4j</groupId>
<artifactId>slf4j-api</artifactId>
</dependency>
<dependency>
<groupId>org.slf4j</groupId>
<artifactId>slf4j-jdk14</artifactId>
</dependency>
Expand Down

0 comments on commit fd84ce5

Please sign in to comment.