4.x - Fix SLF4J binding for annotation processors #7706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add slf4j-api as a dependency to inject/tools. This ensures when the compiler plugin resolves the processor transitive dependencies the resolved version of slf4j-api is the managed version. Otherwise we may end-up with different versions between slf4j-api and slf4j-jdk14 and a failed binding with the warning. Fixes helidon-io#7129
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
changed the title
barchetta
approved these changes
Oct 3, 2023
romain-grecourt
added a commit
to romain-grecourt/helidon
that referenced
this pull request
Oct 6, 2023
- Remove usage of `maven-jaxb2-plugin` (not actually needed, and fails with java.net.MalformedURLException: unknown protocol: maven) - Apply the same fix as helidon-io#7706, add slf4j-api and slf4j-jdk14 (because of handlerbars)
Merged
romain-grecourt
added a commit
that referenced
this pull request
Oct 6, 2023
- Remove usage of `maven-jaxb2-plugin` (not actually needed, and fails with java.net.MalformedURLException: unknown protocol: maven) - Apply the same fix as #7706, add slf4j-api and slf4j-jdk14 (because of handlerbars)
dalexandrov
pushed a commit
to dalexandrov/helidon
that referenced
this pull request
Oct 17, 2023
Add slf4j-api as a dependency to inject/tools. This ensures when the compiler plugin resolves the processor transitive dependencies the resolved version of slf4j-api is the managed version. Otherwise we may end-up with different versions between slf4j-api and slf4j-jdk14 and a failed binding with the warning. Fixes helidon-io#7129
dalexandrov
pushed a commit
to dalexandrov/helidon
that referenced
this pull request
Oct 17, 2023
- Remove usage of `maven-jaxb2-plugin` (not actually needed, and fails with java.net.MalformedURLException: unknown protocol: maven) - Apply the same fix as helidon-io#7706, add slf4j-api and slf4j-jdk14 (because of handlerbars)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
slf4j-apias a dependency to inject/tools to ensure that the version of bothslf4j-apiandslf4j-jdk14are aligned.Fixes #7129
Documentation
No impact.