Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override in config does not work for specific cases #1182

Closed
tomas-langer opened this issue Dec 5, 2019 · 0 comments · Fixed by #1488
Closed

Override in config does not work for specific cases #1182

tomas-langer opened this issue Dec 5, 2019 · 0 comments · Fixed by #1488
Assignees
@tomas-langer
Labels
1.x Issues for 1.x version branch 2.x Issues for 2.x version branch bug Something isn't working config

Comments

@tomas-langer
Copy link
Member

Helidon 1.4.0 + 2.0-SNAPSHOT

The node app1.node1.value in config/config/src/test/resources/io/helidon/config/application.properties cannot be properly overridden.

If you create a value node in a map, and add it as config source, config will not correctly override the value.

This is probably caused by one of them being ObjectNode (the one from properties) and the other a ValueNode (the one from map).

This should work both ways - e.g. properties should be capable of overriding a single value in a map and vice versa.
@tomas-langer tomas-langer added the bug Something isn't working label Dec 5, 2019
@tomas-langer tomas-langer changed the title Override Override in config does not work in all cases Dec 5, 2019
@tomas-langer tomas-langer changed the title Override in config does not work in all cases Override in config does not work for specific cases Dec 5, 2019
@tomas-langer tomas-langer mentioned this issue Dec 5, 2019
Merged
@tomas-langer tomas-langer added 1.x Issues for 1.x version branch 2.x Issues for 2.x version branch labels Jan 16, 2020
@tomas-langer tomas-langer self-assigned this Feb 17, 2020
tomas-langer added a commit to tomas-langer/helidon that referenced this issue Mar 11, 2020
@tomas-langer
helidon-io#1182 issue unit test and fix.
c1ef3ea 
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer mentioned this issue Mar 11, 2020
Merged
@tomas-langer tomas-langer mentioned this issue Mar 11, 2020
Merged
tomas-langer added a commit that referenced this issue Mar 11, 2020
@tomas-langer
Fix merging of value nodes in config 2.0 (#1488)
e9ea681 
* #1182 issue unit test and fix.
* MP Reference test.

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomas-langer tomas-langer

Labels
1.x Issues for 1.x version branch 2.x Issues for 2.x version branch bug Something isn't working config
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix merging of value nodes in config 2.0 tomas-langer/helidon
1 participant
@tomas-langer