Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockConnector badly named beans.xml #5068

Closed
2 tasks
danielkec opened this issue Oct 4, 2022 · 1 comment · Fixed by #5069 or #5070
Closed
2 tasks

MockConnector badly named beans.xml #5068

danielkec opened this issue Oct 4, 2022 · 1 comment · Fixed by #5069 or #5070
Assignees
@danielkec
Labels
bug Something isn't working
Projects
3.0.2 Backlog
Milestone
3.0.2

Comments

@danielkec
Copy link
Contributor

danielkec commented Oct 4, 2022 •
edited
Loading

Environment Details

  • Helidon Version: 3.0.1

Problem Description

MockConnector doesn't get scanned by weld since bean.xml should be beans.xml, note the missing s!

PRs
@danielkec danielkec self-assigned this Oct 4, 2022
@danielkec danielkec added this to the 3.0.2 milestone Oct 4, 2022
@danielkec danielkec added this to To do in 3.0.2 via automation Oct 4, 2022
@github-actions github-actions bot added this to Triage in Backlog Oct 4, 2022
danielkec added a commit to danielkec/helidon that referenced this issue Oct 4, 2022
@danielkec
Bad beans.xml name fix helidon-io#5068
2f16113 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec mentioned this issue Oct 4, 2022
Merged
@danielkec danielkec added the bug Something isn't working label Oct 4, 2022
danielkec added a commit to danielkec/helidon that referenced this issue Oct 4, 2022
@danielkec
Bad beans.xml name fix helidon-io#5068
d03856a 
Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@danielkec danielkec mentioned this issue Oct 4, 2022
Merged
@danielkec
Copy link
Contributor Author

Workaround - Create in your project following bean:

import jakarta.enterprise.context.ApplicationScoped;
import io.helidon.messaging.connectors.mock.MockConnector;
import io.helidon.messaging.connectors.mock.TestConnector;
import org.eclipse.microprofile.reactive.messaging.spi.Connector;

@TestConnector
@ApplicationScoped
@Connector(MockConnector.CONNECTOR_NAME)
public class MockConnectorSurrogate extends MockConnector {
}

@danielkec danielkec moved this from Triage to Sprint Scope in Backlog Oct 4, 2022
romain-grecourt pushed a commit that referenced this issue Oct 4, 2022
@danielkec
5068 mock connector beans xml 3x (#5069)
8f72f01 
* Bad beans.xml name fix #5068

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

* Messaging module info update

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
Backlog automation moved this from Sprint Scope to Closed Oct 4, 2022
danielkec added a commit that referenced this issue Oct 5, 2022
@danielkec
5068 mock connector beans xml 4x (#5070)
01fe7c1 
* Bad beans.xml name fix #5068

Signed-off-by: Daniel Kec <daniel.kec@oracle.com>
@barchetta barchetta moved this from To do to In progress in 3.0.2 Oct 5, 2022
@barchetta barchetta moved this from In progress to Done in 3.0.2 Oct 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielkec danielkec

Labels
bug Something isn't working
Projects
Backlog
  
Closed
3.0.2
Done
Milestone
3.0.2
1 participant
@danielkec