Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: Explore whether setting the connection pool name in UCP to the data source name is a good idea #8345

Closed
ljnelson opened this issue Feb 7, 2024 · 0 comments · Fixed by #8359
Closed

4.x: Explore whether setting the connection pool name in UCP to the data source name is a good idea #8345

ljnelson opened this issue Feb 7, 2024 · 0 comments · Fixed by #8359
Assignees
@ljnelson
Labels
4.x Version 4.x cdi CDI enhancement New feature or request jpa/jta P4

Comments

@ljnelson
Copy link
Member

ljnelson commented Feb 7, 2024 •
edited
Loading

Title says it all.

(Well, almost all.)

One of the Java Beans properties UCP's PoolDataSource exposes is connectionPoolName.

Obviously, if the user has specified this, we honor it. But if the user has not specified it, we currently do nothing. But given that we have a name for this data source (or our CDI integration wouldn't be firing in the first place), it seems like we should default this pool name to the name of the data source being created.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ljnelson ljnelson

Labels
4.x Version 4.x cdi CDI enhancement New feature or request jpa/jta P4
Projects
Backlog
Archived in project
Milestone
No milestone
1 participant
@ljnelson