4.x: Installs a convenient default for connectionPoolName in UCPBackedDataSourceExtension when appropriate #8359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…SourceExtension when appropriate Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
ljnelson
changed the title
|
That test failure is wild and cannot be reproduced locally. I'm guessing the UCP machinery irritatingly keeps |
…peline Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
tjquinno
approved these changes
Feb 10, 2024
| // You can create the pool without a name... | ||
| ucpManager.createConnectionPool((UniversalConnectionPoolAdapter)pds); | ||
| String[] names = ucpManager.getConnectionPoolNames(); | ||
| assertThat("Connection pool names: " + java.util.Arrays.asList(names), names.length, is(1)); |
There was a problem hiding this comment.
For future consideration...
assertThat("Connection pool names: ", names, arrayWithSize(1));
3 tasks
hrstoyanov
pushed a commit
to hrstoyanov/helidon
that referenced
this pull request
Feb 23, 2024
…dDataSourceExtension when appropriate (helidon-io#8359) * Installs a convenient default for connectionPoolName in UCPBackedDataSourceExtension when appropriate Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Squashable commit; diagnosing test failure that occurs only in the pipeline Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Squashable commit; destroys static connection pools after every test Signed-off-by: Laird Nelson <laird.nelson@oracle.com> --------- Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
tvallin
pushed a commit
to tvallin/helidon
that referenced
this pull request
Feb 28, 2024
…dDataSourceExtension when appropriate (helidon-io#8359) * Installs a convenient default for connectionPoolName in UCPBackedDataSourceExtension when appropriate Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Squashable commit; diagnosing test failure that occurs only in the pipeline Signed-off-by: Laird Nelson <laird.nelson@oracle.com> * Squashable commit; destroys static connection pools after every test Signed-off-by: Laird Nelson <laird.nelson@oracle.com> --------- Signed-off-by: Laird Nelson <laird.nelson@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR calls
PoolDataSource#setConnectionPoolName(String)with the value of the@Namedannotation for which a data source is being manufactured, when no connection pool name has otherwise been set.