4.x: Introduces Pico Builder #5195
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spericas
reviewed
Oct 18, 2022
pico/types/src/main/java/io/helidon/pico/types/DefaultTypedElementName.java
Outdated
Show resolved
Hide resolved
romain-grecourt
force-pushed
the
pico2
branch
from
9122594
to
255832f
Compare
spericas
reviewed
Oct 19, 2022
| @@ -48,7 +48,7 @@ | |||
| <module>api</module> | |||
| <!-- <module>spi</module>--> | |||
| <module>types</module> | |||
| <!-- <module>builder</module>--> | |||
| <module>builder</module> | |||
| <!-- <module>config</module>--> | |||
There was a problem hiding this comment.
I'm assuming all these other modules will come in a future PR, right?
spericas
approved these changes
Oct 19, 2022
There was a problem hiding this comment.
Technically, this PR is perfectly sound and clear, and that is why I'm approving it. Architecturally, I have some concerns about adding (mostly independent and potentially "sold" separately) "Pico" modules into the Helidon repo. This is also emphasized by the current naming that uses "Helidon Pico" as opposed to just "Helidon" for naming modules.
It would be nice to get others to review this PR as well.
oracle-contributor-agreement
bot
added
the
OCA Verified
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.