Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support customize encoder and media context in Nima WebServer (#5256) #5257

Merged
merged 2 commits into from Nov 1, 2022
Merged

Support customize encoder and media context in Nima WebServer (#5256) #5257

merged 2 commits into from Nov 1, 2022

Conversation

joeyleeeeeee97
Copy link
Contributor

Please take a look, Thanks.

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. label Oct 26, 2022
@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

@joeyleeeeeee97 joeyleeeeeee97 mentioned this pull request Oct 26, 2022
Closed
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Oct 27, 2022
@joeyleeeeeee97
Copy link
Contributor Author

@romain-grecourt
Hi~, please take a look . Thanks

@joeyleeeeeee97
Copy link
Contributor Author

@tomas-langer Hi~, please take a look. Thanks

tomas-langer
tomas-langer requested changes Oct 31, 2022
View reviewed changes
...er/webserver/src/test/java/io/helidon/nima/webserver/builder/ContentEncodingContextTest.java Outdated Show resolved Hide resolved
...er/webserver/src/test/java/io/helidon/nima/webserver/builder/ContentEncodingContextTest.java Outdated Show resolved Hide resolved
...er/webserver/src/test/java/io/helidon/nima/webserver/builder/ContentEncodingContextTest.java Outdated Show resolved Hide resolved
...er/webserver/src/test/java/io/helidon/nima/webserver/builder/ContentEncodingContextTest.java Outdated Show resolved Hide resolved
...er/webserver/src/test/java/io/helidon/nima/webserver/builder/ContentEncodingContextTest.java Outdated Show resolved Hide resolved
nima/webserver/webserver/src/test/java/io/helidon/nima/webserver/builder/MediaContextTest.java Outdated Show resolved Hide resolved
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. and removed OCA Verified All contributors have signed the Oracle Contributor Agreement. labels Nov 1, 2022
@oracle-contributor-agreement
Copy link

Thank you for your pull request and welcome to our community! To contribute, please sign the Oracle Contributor Agreement (OCA).
The following contributors of this PR have not signed the OCA:

To sign the OCA, please create an Oracle account and sign the OCA in Oracle's Contributor Agreement Application.

When signing the OCA, please provide your GitHub username. After signing the OCA and getting an OCA approval from Oracle, this PR will be automatically updated.

If you are an Oracle employee, please make sure that you are a member of the main Oracle GitHub organization, and your membership in this organization is public.

tomas-langer
tomas-langer previously approved these changes Nov 1, 2022
View reviewed changes
Copy link
Member

@tomas-langer tomas-langer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution!

@tomas-langer
Copy link
Member

@joeyleeeeeee97

Hi, there seems to be some inconsistency in the users you used to create the commit and the PR.
I see this:
joeylee authored and joey.li committed 8 hours ago, yet your OCA is signed for joeyleeeeeee97

It seems our OCA checker is failing on this.
I think what we need to see in the "Commit" pane is:
joeyleeeeeee97 committed 8 hours ago

If you could fix this please, we could continue with pipeline builds...

@joeyleeeeeee97 joeyleeeeeee97 force-pushed the issue_5256 branch 2 times, most recently from 83d1470 to 2ad80ce Compare November 1, 2022 14:35
@joeyleeeeeee97
Copy link
Contributor Author

joeyleeeeeee97 commented Nov 1, 2022 •
edited

Now my oca check seems ok, and now added missing copyright for my two tests.
@tomas-langer I will keep an eye on the test results for failures when it started, could you help me trigger it ? Thanks

@joeyleeeeeee97 joeyleeeeeee97 force-pushed the issue_5256 branch 4 times, most recently from 1dab831 to aeee4f0 Compare November 1, 2022 14:57
@oracle-contributor-agreement oracle-contributor-agreement bot added OCA Verified All contributors have signed the Oracle Contributor Agreement. and removed OCA Required At least one contributor does not have an approved Oracle Contributor Agreement. labels Nov 1, 2022
@tomas-langer tomas-langer merged commit 57c62da into helidon-io:main Nov 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomas-langer tomas-langer tomas-langer approved these changes

Assignees
No one assigned
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joeyleeeeeee97 @tomas-langer