Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #7230 - JDBC type specific setters based on EclipseLink #7246

Merged
merged 1 commit into from Jul 25, 2023
Merged

Issue #7230 - JDBC type specific setters based on EclipseLink #7246

merged 1 commit into from Jul 25, 2023

Conversation

Tomas-Kraus
Copy link
Member

This adds type specific setters from EclipseLink DatabasePlatform class.
Added config blueprint for options to customize setters.

@Tomas-Kraus Tomas-Kraus self-assigned this Jul 25, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 25, 2023
@Tomas-Kraus Tomas-Kraus force-pushed the issue-7230 branch 2 times, most recently from ac254fb to 2945b44 Compare July 25, 2023 16:08
@Tomas-Kraus
Issue helidon-io#7230 - JDBC type specific setters based on EclipseLink
a450be2 
Signed-off-by: Tomáš Kraus <tomas.kraus@oracle.com>
romain-grecourt
romain-grecourt approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could further improve the setParameter method with switch pattern matching however I think we should wait until IntelliJ adds supports for Java 21.

@romain-grecourt romain-grecourt merged commit 7442d44 into helidon-io:main Jul 25, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@tomas-langer tomas-langer Awaiting requested review from tomas-langer

Assignees

@Tomas-Kraus Tomas-Kraus

Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Tomas-Kraus @romain-grecourt