Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.x: Update examples to use Config.global(config) #7655

Merged
merged 3 commits into from
Sep 25, 2023
Merged

4.x: Update examples to use Config.global(config) #7655

merged 3 commits into from
Sep 25, 2023

Conversation

barchetta
Copy link
Member

@barchetta barchetta commented Sep 22, 2023 •
edited
Loading

Description

  • Remove use of io.common.config from examples
  • Use pattern of explicitly initializing global config using Config.global(config)
  • Use pattern of Http Services having a no-arg constructor (use Config.global() instead)

This PR is not necessarily comprehensive. I did not inspect every example, just hit the common and obvious ones.

See Also: #7628

Documentation

No impact

@barchetta barchetta added examples 4.x Version 4.x labels Sep 22, 2023
@barchetta barchetta added this to the 4.0.0-RC1 milestone Sep 22, 2023
@barchetta barchetta self-assigned this Sep 22, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Sep 22, 2023
tjquinno
tjquinno reviewed Sep 24, 2023
View reviewed changes
Copy link
Member

@tjquinno tjquinno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple questions.

examples/cors/src/main/java/io/helidon/examples/cors/Main.java Outdated Show resolved Hide resolved
examples/metrics/filtering/se/src/main/java/io/helidon/examples/metrics/filtering/se/Main.java Show resolved Hide resolved
@barchetta barchetta merged commit 7bc165b into helidon-io:main Sep 25, 2023
12 checks passed
@barchetta barchetta mentioned this pull request Sep 25, 2023
Closed
@tvallin tvallin mentioned this pull request Sep 26, 2023
Closed
@barchetta barchetta deleted the 4.x-examples-api-update branch January 11, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjquinno tjquinno tjquinno approved these changes

@tvallin tvallin tvallin approved these changes

@romain-grecourt romain-grecourt Awaiting requested review from romain-grecourt

Assignees

@barchetta barchetta

Labels
4.x Version 4.x examples OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
Backlog
Archived in project
Milestone
4.0.0-RC1
Development

Successfully merging this pull request may close these issues.
4 participants
@barchetta @romain-grecourt @tjquinno @tvallin