4.x: Verify Starter with 4.x archetypes #7775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tvallin <thibault.vallin@oracle.com>
Signed-off-by: tvallin <thibault.vallin@oracle.com>
oracle-contributor-agreement
bot
added
the
OCA Verified
romain-grecourt
approved these changes
Oct 11, 2023
This was referenced Oct 12, 2023
dalexandrov
pushed a commit
to dalexandrov/helidon
that referenced
this pull request
Oct 17, 2023
* jpms Signed-off-by: tvallin <thibault.vallin@oracle.com> * review changes Signed-off-by: tvallin <thibault.vallin@oracle.com> * fix Helidon starter Signed-off-by: tvallin <thibault.vallin@oracle.com> --------- Signed-off-by: tvallin <thibault.vallin@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fix #7734
fix #7735
By default, the module-info.java is not generated.
This PR make sure the 4.x archetype workflow is the same than 3.x in
Starter.Documentation
no impact