Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add meter type to JSON metrics metadata output #8057

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

tjquinno
Copy link
Member

@tjquinno tjquinno commented Nov 21, 2023

Description

Resolves #8055

  1. Update JsonFormatter to add the meter type to the JSON metadata output.
  2. Add a public typeName() method to the Meter.Type enum to expose a human-readable, JSON-friendly type.

Documentation

PR includes an update to the example JSON metadata output so it includes the type that now appears (again).

@tjquinno tjquinno self-assigned this Nov 21, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 21, 2023
@tjquinno tjquinno merged commit 5d10cd9 into helidon-io:main Nov 22, 2023
12 checks passed
@tjquinno tjquinno deleted the 4.x-json-meter-type branch November 22, 2023 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.x JSON metrics metadata output omits type
2 participants