Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.x: required fixes to builders and other tooling #8076

Merged
merged 7 commits into from
Nov 30, 2023

Conversation

tomas-langer
Copy link
Member

@tomas-langer tomas-langer commented Nov 27, 2023

Description

Prerequisite for #7957

List of changes:

  • Support for @Deprecated options in Blueprint, uses the documentation from @deprecated javadoc tag, or references another property if used in combination with @Option.Deprecated
  • Class model now supports io.helidon.common.types.Annotation
  • Class model can now disable field sorting and/or static field sorting (if public constant requires private constant)
  • Class model - fix to type handling (done by @Verdent )
  • Class model - fixed tag to deprecated (used to be deprecation)
  • TypeInfo and TypedElementInfo now use enum based AccessModifier and Modifier to simplify usage (also fixed a few bugs where the modifiers were not correctly created)
  • Fixed Blueprint types that were public (and were not detected due to above bug)
  • Fixed blueprint processor to correctly handle javadoc for deprecations
  • Support for checked exceptions in TypedElementInfo (required for interceptor processing in follow up PRs)
  • Support for originating element in TypeInfo and TypedElementInfo (useful whend doing anotation processing, so we can correctly report problems with a reference to the element that caused them - used in follow up PRs)

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Fixes in TypeInfoFactory to correctly handle access modifier
Fixes in blueprints that very (incorrectly) public
Support for custom type annotation for blueprint options
Fixes in blueprint processor (correct javadoc)
Support for checked exceptions in TypeInfoFactory and TypedElementInfo
Support for originating element in TypedElementInfo and TypeInfo

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
@tomas-langer tomas-langer added 4.x Version 4.x declarative Helidon Declarative builder Related to the builder support labels Nov 27, 2023
@tomas-langer tomas-langer self-assigned this Nov 27, 2023
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Nov 27, 2023
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Javadoc reference fix

Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
trentjeff
trentjeff previously approved these changes Nov 29, 2023
Copy link
Contributor

@danielkec danielkec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a cosmetic suggestion

@tomas-langer tomas-langer merged commit 08fb215 into helidon-io:main Nov 30, 2023
12 checks passed
@tomas-langer tomas-langer deleted the 7957-inject-collateral branch November 30, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4.x Version 4.x builder Related to the builder support declarative Helidon Declarative OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants