4.x: required fixes to builders and other tooling #8076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Fixes in TypeInfoFactory to correctly handle access modifier Fixes in blueprints that very (incorrectly) public Support for custom type annotation for blueprint options Fixes in blueprint processor (correct javadoc) Support for checked exceptions in TypeInfoFactory and TypedElementInfo Support for originating element in TypedElementInfo and TypeInfo Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
tomas-langer
added
4.x
oracle-contributor-agreement
bot
added
the
OCA Verified
Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
Javadoc reference fix Signed-off-by: Tomas Langer <tomas.langer@oracle.com>
danielkec
reviewed
Nov 28, 2023
trentjeff
reviewed
Nov 28, 2023
builder/processor/src/main/java/io/helidon/builder/processor/AnnotationDataOption.java
Outdated
Show resolved
Hide resolved
builder/processor/src/main/java/io/helidon/builder/processor/AnnotationDataOption.java
Show resolved
Hide resolved
builder/tests/common-types/src/main/java/io/helidon/common/types/ElementKind.java
Show resolved
Hide resolved
trentjeff
previously approved these changes
Nov 29, 2023
danielkec
reviewed
Nov 29, 2023
common/processor/class-model/src/main/java/io/helidon/common/processor/classmodel/Content.java
Outdated
Show resolved
Hide resolved
danielkec
reviewed
Nov 30, 2023
common/processor/processor/src/main/java/io/helidon/common/processor/TypeInfoFactory.java
Show resolved
Hide resolved
danielkec
approved these changes
Nov 30, 2023
Verdent
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prerequisite for #7957
List of changes:
@Deprecatedoptions inBlueprint, uses the documentation from@deprecatedjavadoc tag, or references another property if used in combination with@Option.Deprecatedio.helidon.common.types.Annotationdeprecated(used to bedeprecation)TypeInfoandTypedElementInfonow use enum basedAccessModifierandModifierto simplify usage (also fixed a few bugs where the modifiers were not correctly created)Blueprinttypes that were public (and were not detected due to above bug)TypedElementInfo(required for interceptor processing in follow up PRs)TypeInfoandTypedElementInfo(useful whend doing anotation processing, so we can correctly report problems with a reference to the element that caused them - used in follow up PRs)