Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check result of Integer.parseUnsignedInt() to be non-negative #8215

Merged
merged 2 commits into from Jan 10, 2024

Conversation

spericas
Copy link
Member

@spericas spericas commented Jan 9, 2024

Description

Check result of Integer.parseUnsignedInt() to be non-negative. Issue #8218.

Documentation

None

@spericas spericas requested a review from ljnelson January 9, 2024 20:14
@spericas spericas self-assigned this Jan 9, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jan 9, 2024
@spericas spericas marked this pull request as draft January 9, 2024 20:14
@spericas spericas force-pushed the parseunsignedint branch 2 times, most recently from 7e9caea to ba8182b Compare January 9, 2024 21:33
Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
@spericas spericas added this to the 4.0.3 milestone Jan 10, 2024
@spericas spericas marked this pull request as ready for review January 10, 2024 18:19
ljnelson
ljnelson previously approved these changes Jan 10, 2024
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I don't like the name ParserHelper (does it help parsers?) and I don't like the various invalid size supplier names (do they supply invalid sizes?) but these are minor concerns

Signed-off-by: Santiago Pericasgeertsen <santiago.pericasgeertsen@oracle.com>
Copy link
Member

@ljnelson ljnelson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good enough!

@spericas spericas merged commit 13b4ef0 into helidon-io:main Jan 10, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement. webclient webserver
Projects
Backlog
  
Awaiting triage
Development

Successfully merging this pull request may close these issues.

None yet

2 participants