3.x: Fix wrong description for bean validation annotations (#8667) #8681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
Captain1653
commented
Apr 18, 2024
| @@ -191,6 +193,7 @@ Supported types are: | |||
| |`@Size` | |||
| a|The annotated element size must be between the specified boundaries (included). | |||
| Supported types are: | |||
|
|
|||
There was a problem hiding this comment.
Without this empty line content looks a little wrong.
Example:
With this empty line:
|
@spericas Can you review backport for 3.x? Please :) |
romain-grecourt
approved these changes
Apr 26, 2024
|
Some checks are failed, but I didn't touch them. |
|
@Captain1653 you'll need to rebase this PR with the latest from the helidon-3.x branch. The example build failure is caused by the combination of examples having moved out of this repository and the fact that we did a 3.x release and bumped the 3.x version while this PR has been open. So you need to pick up the pom version change to 3.2.9-SNAPHOST. |
Captain1653
force-pushed
the
3.x-8687-beanvalidation-wrong-description
branch
from
9f07295
to
1b2bd9c
Compare
|
@barchetta Thank you for the explanation. Done. |
romain-grecourt
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #8667
I followed Jakarta Bean Validation Specification