Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[4.x] Server TLS - Add path key description #8937

Merged
merged 2 commits into from
Jul 22, 2024
Merged

[4.x] Server TLS - Add path key description #8937

merged 2 commits into from
Jul 22, 2024

Conversation

tvallin
Copy link
Member

@tvallin tvallin commented Jul 2, 2024

Description

fix #8926

Add description for keystore path resource key.

Documentation

Updated into this PR.

@tvallin tvallin added this to the 4.1.0 milestone Jul 2, 2024
@tvallin tvallin self-assigned this Jul 2, 2024
@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Jul 2, 2024
@tvallin tvallin changed the title Add path key description in docs [4.x] Server TLS - Add path key description Jul 2, 2024
romain-grecourt
romain-grecourt reviewed Jul 2, 2024
View reviewed changes
Copy link
Contributor

@romain-grecourt romain-grecourt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add the missing annotation on Server.Builder#basePath and re-generate the config docs.

@tvallin
Copy link
Member Author

tvallin commented Jul 3, 2024

This is not the same issue, I think you are talking about: #8896

This PR fixes this issue: #8926

@romain-grecourt
Copy link
Contributor

This is not the same issue, I think you are talking about: #8896

This PR fixes this issue: #8926

Ooops, sorry about that.

@tvallin tvallin merged commit 1908a2f into helidon-io:main Jul 22, 2024
12 checks passed
@tvallin tvallin deleted the 4.x-server-doc branch July 22, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romain-grecourt romain-grecourt romain-grecourt approved these changes

@Verdent Verdent Awaiting requested review from Verdent

Assignees

@tvallin tvallin

Labels
4.x Version 4.x docs OCA Verified All contributors have signed the Oracle Contributor Agreement. webserver
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.

[4.x] Server TLS Documentation
2 participants
@tvallin @romain-grecourt