Attempt to read an unconsumed response entity to allow connection caching #8943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oracle-contributor-agreement
bot
added
the
OCA Verified
… be re-used. Optimization only works for length-prefixed entities. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
webclient/http1/src/main/java/io/helidon/webclient/http1/Http1ClientResponseImpl.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
tomas-langer
approved these changes
Jul 16, 2024
barchetta
pushed a commit
to barchetta/helidon
that referenced
this pull request
Jul 16, 2024
…hing (helidon-io#8943) * Attempt to read an unconsumed response entity to allow connections to be re-used. Optimization only works for length-prefixed entities. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com> * Replaces loop by call to skip. Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com> --------- Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
barchetta
added a commit
that referenced
this pull request
Jul 16, 2024
…hing (#8943) (#8996) * Attempt to read an unconsumed response entity to allow connections to be re-used. Optimization only works for length-prefixed entities. * Replaces loop by call to skip. --------- Signed-off-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com> Co-authored-by: Santiago Pericas-Geertsen <santiago.pericasgeertsen@oracle.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Attempt to read an unconsumed response entity to allow connections to be re-used. Optimization only works for length-prefixed entities and when the entity has not been partially read --the goal is not to block the thread attempting to close the response while trying to improve connection caching. Issue #8931.