4.0.11: Convert ConcurrentHashMap which does service loading to HashMap with reentrant lock
#8991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ith `ReentrantLock` (helidon-io#8977) * Convert ConcurrentHashMap which does service loading to HashMap with ReentrantLock Signed-off-by: Tim Quinn <tim.quinn@oracle.com> * Use a RW lock * Replace the contentious ConcurrentHashMap with a HashMap (with the lock) (which was the whole point after all) --------- Signed-off-by: Tim Quinn <tim.quinn@oracle.com>
barchetta
added
backport
oracle-contributor-agreement
bot
added
the
OCA Verified
tjquinno
approved these changes
Jul 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport #8977 to 4.0.11
Resolves #8967
The computeIfAbsent code applied to the SUPPLIERS ConcurrentHashMap performs service loading. Use a HashMap with an explicit guarding lock instead.
Documentation
No impact