Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to QT5 #1

Closed
helioloureiro opened this issue Oct 9, 2018 · 3 comments
Closed

Migrate to QT5 #1

helioloureiro opened this issue Oct 9, 2018 · 3 comments
Labels
enhancement hacktoberfest

Comments

@helioloureiro
Copy link
Owner

Since QT5 is already release and even the main raspberrypi distro moved toward the recent Debian stretch release, which is qt5 based, it is time to update it.
dankolbrs added a commit to dankolbrs/raspresenterpy that referenced this issue Oct 12, 2018
@dankolbrs
[pyqt5] update for pyqt5
b5f6bc6 
Update for pyqt5

Update import statements

Update PyQt5 libraries for changes from 4->5

Update print statements to functions (not necessarily required
for PyQt5)

Update signal usage for PyQt5

Remove `http://demo.jenkins-ci.org/` from conf that was failing to
load and causing a watchdog failure

Resolves helioloureiro#1
@dankolbrs dankolbrs mentioned this issue Oct 12, 2018
Merged
@dankolbrs
Copy link
Contributor

Hey @helioloureiro! Thanks for using the hacktoberfest label!

I've got PR #2 for the PyQt5 changes. Let me know in there if you've got other changes you'd like to see.

Also, how do you feel about some general flake updates? I'd be happy to do another PR on this to take care of some of PEP formatting issues.

@helioloureiro
Copy link
Owner Author

Greate work!

I will create more two issues so you can close them and count for #hacktoberfest (actually commits are enough, but well... get more visibility).

@helioloureiro
Copy link
Owner Author

Hey @helioloureiro! Thanks for using the hacktoberfest label!

I've got PR #2 for the PyQt5 changes. Let me know in there if you've got other changes you'd like to see.

Also, how do you feel about some general flake updates? I'd be happy to do another PR on this to take care of some of PEP formatting issues.

It is there: #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@helioloureiro @dankolbrs