Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pyqt5] update for pyqt5 #2

Merged
merged 1 commit into from Oct 12, 2018
Merged

[pyqt5] update for pyqt5 #2

merged 1 commit into from Oct 12, 2018

Conversation

dankolbrs
Copy link
Contributor

Update for pyqt5

Update import statements

Update PyQt5 libraries for changes from 4->5

Update print statements to functions (not necessarily required
for PyQt5)

Update signal usage for PyQt5

Remove http://demo.jenkins-ci.org/ from conf that was failing to
load and causing a watchdog failure

Resolves #1

@dankolbrs
[pyqt5] update for pyqt5
b5f6bc6 
Update for pyqt5

Update import statements

Update PyQt5 libraries for changes from 4->5

Update print statements to functions (not necessarily required
for PyQt5)

Update signal usage for PyQt5

Remove `http://demo.jenkins-ci.org/` from conf that was failing to
load and causing a watchdog failure

Resolves helioloureiro#1
@dankolbrs dankolbrs mentioned this pull request Oct 12, 2018
Closed
@dankolbrs
Copy link
Contributor Author

Removed http://demo.jenkins-ci.org/ from the conf as this was failing to load locally and killing the app. I can add that back in if its only an issue on my machine.

helioloureiro
helioloureiro approved these changes Oct 12, 2018
View reviewed changes
Copy link
Owner

@helioloureiro helioloureiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@helioloureiro helioloureiro merged commit 6e16c73 into helioloureiro:master Oct 12, 2018
@dankolbrs dankolbrs deleted the pyqt5 branch October 12, 2018 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helioloureiro helioloureiro helioloureiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dankolbrs @helioloureiro