This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
If a snapshot listed in latest.json is interrupted when loading, fix it #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous to this change if a latest.json snap was loading and it was interrupted (OOM, unplug, power loss, etc) the node would get stuck trying to sync with an incomplete chain because the code didn't check the latest.json snap when initializing the chain, only once the chain had started. This would lead to a blessed snapshot in the config file being "older" than the chain, but the chain being incomplete as a result of an interrupted snapshot load from a latest.json snapshot at a higher height.
evanmcc
approved these changes
Dec 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous to this change if a latest.json snap was loading and it was
interrupted (OOM, unplug, power loss, etc) the node would get stuck
trying to sync with an incomplete chain because the code didn't check
the latest.json snap when initializing the chain, only once the chain
had started. This would lead to a blessed snapshot in the config file
being "older" than the chain, but the chain being incomplete as a result
of an interrupted snapshot load from a latest.json snapshot at a higher
height.