This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
Fix incorrect witness bad rssi check #326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
vihu
commented
Dec 18, 2019
vihu
commented
- Hide behind PoC V6
- Hide behind PoC V6
vihu
force-pushed
the
rg/fix-incorrect-bad-rssi-witness-check
branch
from
a176bf4
to
17121e1
Compare
Codecov Report
@@ Coverage Diff @@
## master #326 +/- ##
==========================================
+ Coverage 70.1% 70.13% +0.02%
==========================================
Files 66 66
Lines 6303 6304 +1
==========================================
+ Hits 4419 4421 +2
+ Misses 1884 1883 -1
Continue to review full report at Codecov.
|
evanmcc
previously approved these changes
Dec 19, 2019
evanmcc
reviewed
Dec 19, 2019
| @@ -326,10 +326,16 @@ check_witness_bad_rssi(Witness, Vars) -> | |||
| 0 -> | |||
| %% No bad RSSIs found, include | |||
| true; | |||
| BadCount when is_integer(V), V > 5 -> | |||
There was a problem hiding this comment.
in my heart, I would prefer that this be V >= 6, but that is very minor.
evanmcc
approved these changes
Dec 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.