Merge pull request #20 from helium/jsk/ci/enable-clippy-and-fmt

Enable lint and format checks on CI builds
helium · Mar 26, 2020 · ba6f46c · ba6f46c
2 parents 9372a20 + e36e951
commit ba6f46c
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 3 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -33,8 +33,14 @@ matrix:
   - name: Linux Binary
     env: TARGET=x86_64-unknown-linux-musl
     rust: stable
-    before_script: rustup target add $TARGET
-    script: cargo build --release --target $TARGET --locked --features vendored
+    before_script:
+      - rustup target add $TARGET
+      - rustup component add rustfmt
+      - rustup component add clippy
+    script:
+      - cargo fmt -- --check
+      - cargo build --release --target $TARGET --locked --features vendored
+      - cargo clippy -- --deny=clippy::all
     addons:
       apt:
         packages:
@@ -46,6 +52,12 @@ matrix:
     env: MACOSX_DEPLOYMENT_TARGET=10.7 TARGET=x86_64-apple-darwin
     os: osx
     rust: stable
-    script: cargo build --release --target $TARGET --locked
+    before_script:
+      - rustup component add rustfmt
+      - rustup component add clippy
+    script:
+      - cargo fmt -- --check
+      - cargo build --release --target $TARGET --locked
+      - cargo clippy -- --deny=clippy::all
     install: true
     <<: *DEPLOY_TO_GITHUB
diff --git a/src/cmd_htlc.rs b/src/cmd_htlc.rs
@@ -8,6 +8,7 @@ use helium_api::{Client, PendingTxnStatus};
 use helium_proto::{BlockchainTxnCreateHtlcV1, BlockchainTxnRedeemHtlcV1, Txn};
 use prettytable::Table;
 
+#[allow(clippy::too_many_arguments)]
 pub fn cmd_create(
     url: String,
     wallet: &Wallet,